-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading JSON IO tests to the new API, and removing the deprecated API #2104
Conversation
… tests to using the new. This triggers several hidden bugs in the "new" API
…y tuple yet. Towards fixing #2106
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2104 +/- ##
========================================
Coverage 49% 49%
+ Complexity 6336 6234 -102
========================================
Files 667 663 -4
Lines 59836 59181 -655
Branches 8692 8615 -77
========================================
- Hits 29718 29475 -243
+ Misses 27868 27475 -393
+ Partials 2250 2231 -19 ☔ View full report in Codecov by Sentry. |
See if this fixes the crashing surefire fork
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I have a few small concerns, but I'm very happy to see a whole bunch of old code get cleaned up 👍🏼
src/org/rascalmpl/library/lang/rascal/tests/library/lang/json/JSONIOTests.rsc
Outdated
Show resolved
Hide resolved
I want to increase the test coverage a bit before merging this |
…cise than doubles
Test coverage can be increased a lot by testing the different nul representations. I'm leaving that for another PR since this one is already quite big. |
datetime
values by reusing features from theDateTime
modulelang::json::IO
and removed their respective implementation classes inlang/json/io/internal
node
values by encoding their name as a_name
field of the object.num
value
by normalizing the expected values to the defaults that are chosen when no more specific type is requestednum
,value
andnode