Fixed logic around fallback resolver in URIResolverRegistry #2101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavyLandman
reviewed
Dec 16, 2024
DavyLandman
approved these changes
Dec 16, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2101 +/- ##
========================================
Coverage 49% 49%
- Complexity 6317 6336 +19
========================================
Files 666 667 +1
Lines 59695 59836 +141
Branches 8670 8692 +22
========================================
+ Hits 29600 29709 +109
- Misses 27863 27873 +10
- Partials 2232 2254 +22 ☔ View full report in Codecov by Sentry. |
DavyLandman
reviewed
Dec 17, 2024
| var fallBack = fallbackLogicalResolver; | ||
| if (fallBack != null) { | ||
| return resolveAndFixOffsets(loc == null ? original : loc, fallBack, Collections.emptyList()); | ||
| if (loc == null) { |
There was a problem hiding this comment.
this is not the right place for this check, it changes the logic of the case where there is no fallbackLogicalResolver defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a (latent) bug where the result of logical source location resolution would be de facto discarded by the fallback resolver returning
null. This popped up during evolution of theFallbackResolverclass in therascal-lspproject.