Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce condition #783

Conversation

nepridumalnik
Copy link
Contributor


Note: by creating a PR or an issue you automatically agree to the CLA. See CONTRIBUTING.md. Feel free to remove this note, the agreement holds.

@apolukhin
Copy link
Member

Fails to compile with message

/home/runner/work/userver/userver/otlp/src/otlp/logs/logger.cpp:233:31: error: invalid operands to binary expression ('const SinkType' and 'userver_ns::otlp::SinkType')
  233 |         if (config_.logs_sink & SinkType::kOtlp) {
      |             ~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~
/home/runner/work/userver/userver/otlp/src/otlp/logs/logger.cpp:236:34: error: invalid operands to binary expression ('const SinkType' and 'userver_ns::otlp::SinkType')
  236 |         if (config_.tracing_sink & SinkType::kOtlp) {
      |             ~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~
2 errors generated.

@nepridumalnik
Copy link
Contributor Author

Added static_cast to fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants