Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyyaml 5.4.* is giving problems upon installation #97

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

bedroesb
Copy link
Collaborator

I am locking to the latest version that does not give the same error as described here: yaml/pyyaml#723 (comment)

@bedroesb
Copy link
Collaborator Author

this did fix the problem while using pip install git+https://github.com/usegalaxy-eu/ena-upload-cli.git@bedroesb-patch-1

@bedroesb bedroesb requested a review from bgruening September 24, 2024 21:34
@bedroesb
Copy link
Collaborator Author

Problem was occurred using python 3.9 on MacOS and python 3.12 on windows. I could not recreate it on a new env using python 3.11 on Ubuntu.

@bgruening
Copy link
Member

Could you maybe add a comment to the file why we pin it?
Is conda also affected?

@bedroesb
Copy link
Collaborator Author

@bgruening good idea! TO be fair is it not nice to keep the dependencies a bit in sync anyway? I can update the conda recipe too

@bgruening
Copy link
Member

TO be fair is it not nice to keep the dependencies a bit in sync anyway?

Simple english for old dudes please? :)
Not sure what you mean :)

@bedroesb
Copy link
Collaborator Author

haha sorry! I meant that I before tried to keep the conda recipe https://github.com/bioconda/bioconda-recipes/blob/71ad73ff33361ac2964a64e55a9159f8cac37697/recipes/ena-upload-cli/meta.yaml#L29 in sync with the requirements.txt file, and I would continue doing so if that's ok.

@bgruening bgruening merged commit a566567 into master Sep 25, 2024
3 checks passed
@bgruening bgruening deleted the bedroesb-patch-1 branch September 25, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants