bugfix(#2431) Refactor URL construction in Postman collection processing #2445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietrygamat
reviewed
Aug 2, 2024
Comment on lines
57
to
72
| const constructUrl = (url) => { | ||
| let urlStr = ''; | ||
| if (typeof url === 'string') { | ||
| urlStr = url; | ||
| } else if (url.raw) { | ||
| urlStr = url.raw; | ||
| } else { | ||
| const { protocol, host, path, port, query } = url; | ||
| const hostStr = Array.isArray(host) ? host.join('.') : host; | ||
| const pathStr = Array.isArray(path) ? path.join('/') : path; | ||
| const portStr = port ? `:${port}` : ''; | ||
| const queryStr = query && query.length > 0 ? `?${query.map((q) => `${q.key}=${q.value}`).join('&')}` : ''; | ||
| urlStr = `${protocol}://${hostStr}${portStr}/${pathStr}${queryStr}`; | ||
| } | ||
| return urlStr; | ||
| }; |
There was a problem hiding this comment.
Check this case please, this is losing hash section of url:
"item": [
{
"name": "Request",
"request": {
"method": "GET",
"header": [],
"url": {
"raw": "https://localhost/param1/param2?param3¶m4=b¶m5=(size=small;color=red)#this-is-framgment",
"protocol": "https",
"host": [
"localhost"
],
"path": [
"param1",
"param2"
],
"query": [
{
"key": "param3",
"value": null
},
{
"key": "param4",
"value": "b"
},
{
"key": "param5",
"value": "(size=small;color=red)"
}
],
"hash": "this-is-framgment"
}
},
"response": []
}
]
There was a problem hiding this comment.
Thank you for the review. I believe we should not include the hash values in the URL. As per Wikipedia,
"The fragment identifier functions differently to the rest of the URI: its processing is exclusively client-sided with no participation from the web server"
— Wikipedia
…en there is a param with its key as undefined we discard it.
2 tasks
sanjai0py
requested review from
pietrygamat and
anusreesubash
and removed request for
pietrygamat
anusreesubash
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2431
Fixes #3113
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.