Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI/CD for Docker Build and Sonar cloud #18

Merged
merged 31 commits into from
Jun 28, 2023
Merged

Add CI/CD for Docker Build and Sonar cloud #18

merged 31 commits into from
Jun 28, 2023

Conversation

SaikrishnaBairamoni
Copy link
Contributor

This PR is to add the GitHub actions workflows for both docker hub build and to run sonar scan analysis for publishing static reports on sonar cloud dashboard.

Copy link
Contributor

@codygarver codygarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sonar-scanner.properties is not being used by the sonar-scanner in ci.yml

ci.yml is also needs to include tmca-tester

@sonarcloud
Copy link

sonarcloud bot commented Apr 18, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability B 1 Vulnerability
Security Hotspot A 0 Security Hotspots
Code Smell A 12 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@codygarver codygarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See diff comments

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/docker.yml Outdated Show resolved Hide resolved
.github/workflows/docker.yml Outdated Show resolved Hide resolved
.github/workflows/dockerhub.yml Show resolved Hide resolved
.github/workflows/dockerhub.yml Outdated Show resolved Hide resolved
.sonarqube/sonar-scanner.properties Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
.github/workflows/docker.yml Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
Copy link
Contributor

@codygarver codygarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See diff in comments

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
- run: |
cd $GITHUB_WORKSPACE/tmca-tester
npm install --force
npm run build --if-present
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why --if-present?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@codygarver codygarver merged commit b88f08b into develop Jun 28, 2023
8 checks passed
@codygarver codygarver deleted the ci branch June 28, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants