Artifact Publishing, Default Property Value Change, Unit Tests & Documentation Updates #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eation after testing
Changed default value for enable.auto.commit property to 'true'
Github Actions Artifact Publishing
Add Unit Tests
Revised Documentation for Accuracy
…ease-notes Version Change & Release Notes (2024 Q3 Release)
dan-du-car
reviewed
Sep 19, 2024
src/main/java/us/dot/its/jpo/ode/aws/depositor/AwsDepositor.java
Outdated
Show resolved
Hide resolved
…d in `AwsDepositor` class
Removed unused variable declaration
dan-du-car
approved these changes
Sep 20, 2024
| @@ -0,0 +1,31 @@ | |||
| name: Publish Java Package | |||
There was a problem hiding this comment.
What will be the approx. artifact size and where we are using this ? As our ODE GitHub org is on free plan we have artifact storage limit of 500mb.
There was a problem hiding this comment.
The project's JAR file is about 14 KB in size. It is not currently being used, but it is for potential future use.
There was a problem hiding this comment.
Same comment from jpo-security-svcs seems like for Maven packages and other packages like npm, docker, etc storage limit will be not applied for public repo's. so I think we should be good to use artifacts. However for any private repo's this limits will apply. We have a backlog item for supporting GitHub artifacts setup in future release. Thanks!
SaikrishnaBairamoni
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Artifact Publishing
Added a GitHub action workflow to publish a Java artifact to the repository upon release creation.
Default Value Change for enable.auto.commit Property
Problem
The enable.auto.commit property defaults to 'false,' but based on issue #22, 'true' is a more appropriate default.
Solution
The default for enable.auto.commit is now 'true' when the environment variable is not set.
Unit Tests Added
This PR introduces unit tests for S3-depositor methods, along with refactoring to support testability. All changes were tested and validated using Maven.
Documentation Updates
Problem
The README was disorganized and contained inaccuracies.
Solution
The README has been updated for better clarity and accuracy.