Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Intersection Reference and Signal Group Alignment Events #86

Merged
merged 16 commits into from
May 20, 2024

Conversation

iyourshaw
Copy link
Collaborator

@iyourshaw iyourshaw commented May 15, 2024

Fixes the following issues found in integration testing:

  • MAPs and SPaT from the same RSU were not being joined correctly for the Intersection Reference Alignment check.
  • Signal Group Alignment events incorrectly produced when SPAT and MAP signal groups match.

The integration tests are described here:

Verified that after applying the fix, the integration tests pass.

Note that the key of the Intersection Reference Alignment events is changed to be the RSU ID instead or an RsuIntersectionKey object.

@iyourshaw iyourshaw requested a review from John-Wiens May 15, 2024 20:34
@iyourshaw iyourshaw marked this pull request as draft May 15, 2024 20:39
@iyourshaw iyourshaw marked this pull request as ready for review May 15, 2024 22:03
@John-Wiens John-Wiens merged commit ec90c1c into develop May 20, 2024
3 checks passed
@John-Wiens John-Wiens deleted the requirements-review-fixes branch May 20, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants