Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing linter job on Windows #33

Merged
merged 5 commits into from
Nov 12, 2024
Merged

Failing linter job on Windows #33

merged 5 commits into from
Nov 12, 2024

Conversation

abitrolly
Copy link
Contributor

@abitrolly abitrolly commented Nov 11, 2024

Reverting 76f9d18#diff-107e910e9f2ebfb9a741fa10b2aa7100cc1fc4f5f3aca2dfe78b905cbd73c0d2L19 and fixing linter test on Windows.

It needed proper LF line endings.

What type of PR is this?

(REQUIRED)

  • bug
  • cleanup
  • documentation
  • feature

What this PR does / why we need it:

(REQUIRED)

Which issue(s) this PR fixes:

(REQUIRED)

Special notes for your reviewer:

(fill-in or delete this section)

Testing

(fill-in or delete this section)

Release Notes

(REQUIRED)


@abitrolly abitrolly requested a review from a team as a code owner November 11, 2024 20:26
@abitrolly
Copy link
Contributor Author

Log is not very informative. 1888 lines.

\033[32;01mRun vet\033[0m
\033[32;01mRun golangci-lint\033[0m
cmd\genvalues\main.go:1: File is not `goimports`-ed (goimports)
// This generator is for internal usage only.
//
// It generates values described in values.json.
package main
...
// Parse parses cfg, that is a pointer to some structure,
// puts it to the new flag.FlagSet and returns it.
func Parse(cfg interface{}, optFuncs ...sflags.OptFunc) ([]cli.Flag, error) {
	flags := make([]cli.Flag, 0)
	err := ParseTo(cfg, &flags, optFuncs...)
	if err != nil {
		return nil, err
	}
	return flags, nil
}
make: *** [Makefile:33: check] Error 1
Error: Process completed with exit code 1.

But on Mac there is no cmd\genvalues\main.go:1: File is not goimports-ed (goimports) message.

@abitrolly
Copy link
Contributor Author

@dearchap fixed.

Copy link
Member

@Juneezee Juneezee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue was also discussed in golangci/golangci-lint#580 (comment)

@abitrolly abitrolly merged commit 2080286 into main Nov 12, 2024
9 checks passed
@abitrolly abitrolly deleted the windows-tests branch November 12, 2024 05:54
@abitrolly
Copy link
Contributor Author

Opened golang/go#70297 to improve goimports error message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants