Prepare for v1.8.0 #26
Conversation
Based on urfave/cli and this conversation: #23 (comment)
| - Once that is approved and merged make a tag locally: | ||
| ```sh | ||
| TAG_VERSION=v1.7.2 make tag | ||
| git push origin v1.7.2 | ||
| ``` |
There was a problem hiding this comment.
I'm not likely to be making releases, so this is probably a very moot point that I'm happy to concede on, but wouldn't it be the same / sufficient to make the tag via the web UI?
(I haven't set up commit/tag signing locally, for example, so web UI actions are the only way I'll have signed objects. That being said I don't actually use gimme any more and haven't for a long time; I'm just still here because @meatballhat is one of the best humans there ever was and I'm happy to lend a hand if I can since I helped create the thing eons ago. 😄)
There was a problem hiding this comment.
v1.5.1 was signed that way, by crating the tag on the web view, and it does create a signed tag. v1.5.2 isn't signed at all. So I have no objections to the tags being signed by github.
However the tag target in the Makefile refuses to make the tag unless you've updated the version number in source, which we forgot to do for v1.7.0. Presumably because @meatballhat made the tag using git locally. I think let's do our best to protect ourselves and keep this method.
Thank you for making me think about this.
No description provided.