ames: populate gang with fine sender when scrying into arvo #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joemfb
requested changes
Dec 18, 2023
There was a problem hiding this comment.
In refcounting terms this would be fine, but the semantics are not right. "fine" requests are not authenticated, the "receiving ship" in the packet prelude is just a routing implementation detail, and data requested through this codepath will not be limited to the ship in question, but could be exposed to any ship (in transit, via the cache, &c). The request is and needs to be public.
|
Right that all makes sense. Just the responses are signed.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what we actually want to do.
@joemfb am I leaking something here?