Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vere: add --serf-bin option to provide path to serf #566

Merged
merged 1 commit into from
Jan 10, 2024
Merged

vere: add --serf-bin option to provide path to serf #566

merged 1 commit into from
Jan 10, 2024

Conversation

eamsden
Copy link
Contributor

@eamsden eamsden commented Dec 5, 2023 •
edited
Loading

Addresses #564

@eamsden eamsden requested a review from a team as a code owner December 5, 2023 18:53
@eamsden eamsden changed the base branch from develop to master December 5, 2023 18:53
@eamsden
Copy link
Contributor Author

eamsden commented Dec 6, 2023

Thanks @joemfb for direction writing this

@ashelkovnykov ashelkovnykov mentioned this pull request Dec 11, 2023
Open
2 tasks
@matthew-levan matthew-levan merged commit b5cf1d7 into master Jan 10, 2024
5 checks passed
@matthew-levan matthew-levan deleted the ea/choose-serf branch January 10, 2024 17:02
@joemfb
Copy link
Member

joemfb commented Jan 10, 2024

@matthew-levan this needs to be reverted, we can't merge straight to master and this may conflict with 3.0.

@matthew-levan
Copy link
Contributor

oops sry

@matthew-levan matthew-levan mentioned this pull request Jan 10, 2024
Merged
matthew-levan added a commit that referenced this pull request Jan 10, 2024
@matthew-levan
Revert "vere: add --serf-bin option to provide path to serf" (#583)
b553e93 
Reverts #566
@matthew-levan matthew-levan restored the ea/choose-serf branch January 10, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashelkovnykov ashelkovnykov ashelkovnykov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Ares beta
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eamsden @joemfb @matthew-levan @ashelkovnykov