vere: bring your own boot sequence #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the curl fails or receives a non-2xx status code, it retries, backing off a little bit, until it either succeeds, or exceeds five attempts.
Adds support for --prop-file, --prop-url and --prop-name, which let one augment the boot sequence of a ship with additional events. Back-ports the vere changes from urbit/urbit#5470 onto current vere. See that for additional details/history. This is a mostly straightforward, copy-paste port of the changes from that original PR, with the following exceptions: - Boot sequence construction now happens in _pier_boot_make. - We don't modify the way the default boot sequence is acquired (yet). We will want to follow up on the latter, eventually. The %autoprop "prop builder" that was included in #5470 should still operate fine and be useful for automating keeping certain kinds of props up to date. (Save for minimal kelvin compatability disrepair it has fallen into due to the flow of time.)
Fang-
commented
Oct 23, 2023
pkg/vere/king.c
Outdated
Comment on lines
187
to
188
| //TODO should maybe respect ops_u.url_c | ||
| "https://bootstrap.urbit.org/props/" URBIT_VERSION "/%s.jam", |
There was a problem hiding this comment.
I think this might be correct in the long run, but not right now due to interactions between -B and -u, and the fact that we hardcode bootstrap.urbit.org in a handful of other places as well.
There was a problem hiding this comment.
This should use snprintf to check against stack overflow. And you should bump the max size to 256.
Fang-
commented
Oct 23, 2023
Fang-
commented
Oct 23, 2023
joemfb
requested changes
Nov 15, 2023
pkg/vere/king.c
Outdated
Comment on lines
187
to
188
| //TODO should maybe respect ops_u.url_c | ||
| "https://bootstrap.urbit.org/props/" URBIT_VERSION "/%s.jam", |
There was a problem hiding this comment.
This should use snprintf to check against stack overflow. And you should bump the max size to 256.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
--prop-file,--prop-urland--prop-name, which let one augment the boot sequence of a ship with additional events.Back-ports the vere changes from urbit/urbit#5470 onto current vere. See that for additional details/history. This is a mostly straightforward, copy-paste port of the changes from that original PR, with the following exceptions:
_pier_boot_make.We will want to follow up on the latter, eventually. I've left
TODOs in the relevant places. Figured it might be better to be less disruptive to release processes initially. cc @pkovaThe %autoprop "prop builder" that was included in urbit/urbit#5470 should still operate fine and be useful for automatically keeping certain kinds of props up to date. (Save for minimal kelvin compatibility disrepair it has fallen into due to the flow of time.)