ames: resolve galaxy ips using ipv4 only #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some ships experience a lot of printfs like
ames: czar at zod.urbit.org: not found (b)for galaxies that are up and have no problems with their DNS config. I initially thought this was something else, but the problem I found by mucking around withtcpdumpis that we issue both a IPv4 A record query and a IPv6 AAAA record query. When the IPv6 query resolves it thrashes all kinds of state, sometimes causing the spurious printf above.This PR configures
uv_getaddrinfoto return just IPv4 addresses. I also removed the unnecessary while loop.