-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLAKE3 jets #535
BLAKE3 jets #535
Conversation
Anyone on a beefy amd64 machine want to benchmark this? I'm on an M2, so I can't see those juicy AVX-512 speedups. 😭 Still, ~1.2 GB/s ain't bad -- that's 2x faster than sha3, and 4x faster than blake2b. |
It looks like there's some git churn here. Maybe merge develop into your branch? |
cf391f7
to
17e57e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These look good. I've noted a couple issues with one allocation, and an assertion that should be removed.
These jets will go into 411 (or later), so they should not be declared in the hoon %140 cores. I've setup the declarations for 411 (hoon 138) in #567, it'll be simplest for this PR to target that one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will do
See urbit/urbit#6802 and urbit/urcrypt#8
Depends on #524