Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hoon: 138k #526

Merged
merged 5 commits into from
Oct 6, 2023
Merged

hoon: 138k #526

merged 5 commits into from
Oct 6, 2023

Conversation

joemfb
Copy link
Member

@joemfb joemfb commented Sep 27, 2023

@joemfb
Copy link
Member Author

joemfb commented Oct 5, 2023

I've resolved the issue of the interface changes to +bif:by in #439 by simply removing the jet from the dashboard. The implementation is still there, used by +dif:by, but there are no direct calls to the jet. If it's deemed necessary, it can be re-enabled (for 138-only, with more verbose tree.c declarations, or for all kelvins, but adding a version with the old interface).

@joemfb joemfb marked this pull request as ready for review October 6, 2023 16:43
@joemfb joemfb requested a review from a team as a code owner October 6, 2023 16:43
@pkova pkova merged commit 5f372c8 into next/kelvin/411 Oct 6, 2023
5 checks passed
@pkova pkova deleted the next/hoon/138 branch October 6, 2023 16:44
@joemfb joemfb mentioned this pull request Dec 6, 2023
Merged
pkova added a commit that referenced this pull request Dec 11, 2023
@pkova
jets: declare %138 separately (#567)
5b8c3fd 
We were previously reusing the %139 declarations for %138. But
urbit/urbit#6859 requires that we remove jets in %138, and #439 required
that we remove a jet in prior versions (temporarily handled by removing
it from all versions in #526).

Additionally, this PR removes obsolete and unused jets and hooks for
`+hike` and `|ap`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joemfb @pkova @ashelkovnykov