Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test_file.py tests parallelizable #202

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Peque
Copy link
Contributor

@Peque Peque commented Jan 6, 2017

Just a small change that makes tests in test_file.py parallelizable. This is useful for being able to run tests in parallel with pytest (i.e.: pytest -n 8).

Note that pytest-xdist module is required in order to use the -n option with pytest.

@mmckerns
Copy link
Member

This file takes little to no time to run as is. Your point is that with these changes, all the tests can run in parallel?

@Peque
Copy link
Contributor Author

Peque commented Jan 23, 2017

@mmckerns That is exactly my point, yes. 😊

@matsjoyce
Copy link
Contributor

Futureproofing!

Copy link
Member

@mmckerns mmckerns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is fine, in general. I'd rather not have a print in clean_artifact. It seems unnecessary, can you remove it?

@Peque
Copy link
Contributor Author

Peque commented Jan 23, 2017

@mmckerns Removed unnecessary print.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants