Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid partial matching #328

Merged
merged 1 commit into from
May 10, 2024
Merged

Avoid partial matching #328

merged 1 commit into from
May 10, 2024

Conversation

olivroy
Copy link
Contributor

@olivroy olivroy commented May 7, 2024

Caught by using

  options(
    warnPartialMatchArgs = TRUE,
    warnPartialMatchDollar = TRUE,
    warnPartialMatchAttr = TRUE
  )

@bburns632
Copy link
Collaborator

@olivroy thanks for the catch! (reference doc here)

Could you elaborate on when you specified those options to catch this error? Was it directly before a CreatePackageReport() call?

@olivroy
Copy link
Contributor Author

olivroy commented May 7, 2024

yes indeed!

with the options set, just run CreatePackageReport("ggplot2") and you should see a warning on the cran version of pkgnet

@bburns632 bburns632 self-requested a review May 10, 2024 14:30
@bburns632 bburns632 merged commit 84a3cf4 into uptake:main May 10, 2024
3 checks passed
@olivroy olivroy deleted the patch-1 branch May 10, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants