[RN-85] 맛집 리스트 및 랭킹 페이지 구현 #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eunbae0
requested changes
Jun 8, 2024
Comment on lines
32
to
42
| const locationList = ['전체', '정문', '후문']; | ||
| const foodCategoryList = [ | ||
| '전체', | ||
| '한식', | ||
| '일식', | ||
| '중식', | ||
| '양식', | ||
| '분식', | ||
| '간편식', | ||
| '기타', | ||
| ]; |
There was a problem hiding this comment.
바뀔 수 있는 상수는 해당 도메인 폴더에 constant 폴더를 생성해서 따로 관리하는 것을 추천합니다
| const navigation = useNavigation<RootNavigationProps>(); | ||
| const [bottomSheetItem, setBottomSheetItem] = | ||
| useState<RestaurantItemType | null>(); | ||
| const [openBottomSheet, closeBottomSheet, BottomSheet] = |
There was a problem hiding this comment.
closeBottonSheet()함수를 사용하지 않는다면 _ underscore로 지정하시면 알아보기 좋을 것 같습니다.
There was a problem hiding this comment.
underscore 사용하면 eslint 위반되는데 그대로 진행시키면 되나요..?
Comment on lines
14
to
21
| export type RestaurantItemType = { | ||
| name: string; | ||
| location: string; | ||
| restaurantType: string; | ||
| like: boolean; | ||
| likesCount: number; | ||
| mapLink: string; | ||
| }; |
There was a problem hiding this comment.
해당 TF에서 전체적으로 사용하는 타입이라, 도메인애 types 폴더를 만들어서 따로 관리하면 좋을 것 같습니다.
merge origin/RN-85 to RN-85
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key Changes
To Reviewers
현재 RestaurantScreen에서 맛집 리스트 요소 press 시 하단 모달을 띄우기 위해 state(bottomSheetItem)를 사용하고 있습니다.
state로 bottomSheet에 선택된 요소 정보를 전달하는 방법 이외에 다른 방법이 있을까요?
BorderSelect 컴포넌트에서 boxShadow 스타일 적용이 안되는데 이유를 모르겠습니다!
도서관 순위 페이지에서도 Select 컴포넌트에서 적용이 안된 것 같습니다.