시대생 프론트엔드 과제 1 PR 이소은 #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Features
Tests
Commit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
ratafa
reviewed
Oct 17, 2023
| <S.cafeteriaWrapper> | ||
| <S.locationWrapper> | ||
| <Text | ||
| text={cafeteria.location} |
There was a problem hiding this comment.
태그 사이에 들어갈 요소가 없다면 '< Text />' 로 간결하게 태그를 표현하는 방법도 있습니당
| text={cafeteria.openingHours} | ||
| fontSize={15} | ||
| fontWeight={500} | ||
| color="#808A98" |
There was a problem hiding this comment.
반복적인 color 값이 들어간다면 해당 값을 상수로 정하시거나, config 폴더를 따로 제작하여 값을 관리하는 방법도 좋아 보여요
| return ( | ||
| <S.textWrapper width={width} lineHeight={lineHeight}> | ||
| <S.text | ||
| text={text} |
There was a problem hiding this comment.
styled-component로 제작된 S.text 컴포넌트에 text 속성이 사용되어지지 않기에, 필요하지 않는 props라고 생각됩니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
Test