Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UOSLIFE-Assignment-FE-1 #2

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

UOSLIFE-Assignment-FE-1 #2

wants to merge 9 commits into from

Conversation

Chaehee03
Copy link

  • Text 컴포넌트, Cafteria 컴포넌트 작성.
  • 스토리북 작성.

@commit-lint
Copy link

commit-lint bot commented Jul 2, 2023

Contributors

Chaehee03

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

ratafa
ratafa approved these changes Jul 4, 2023
View reviewed changes
Copy link

@ratafa ratafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다. :)

src/components/Cafeteria/Cafeteria.style.tsx
@@ -0,0 +1,58 @@
import styled from "styled-components";

export const TabContainer = styled("div")`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

styled.div``;으로도 사용 가능합니다.

src/components/Text/Text.tsx
};

export default Text;
const StyledText = styled.div<TextProps>`
font-size: ${(props) => props.fontSize}px;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

객체 비구조화 할당을 사용하여
font-size: ${({fontSize}) => fontSize}px 로도 사용 가능합니다

src/components/Cafeteria/Cafeteria.tsx

export default Cafeteria;
export const Cafeteria = ({ cafeteria }: any) => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any 대신 Cafeteria.type을 가져다쓰면 좋을 것 같습니다!

src/components/Cafeteria/Cafeteria.tsx
color="#656D78"
/>
</InfoTime>
</InfoContent1>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

변수명을 다른 개발자들도 알아볼 수 있도록 잘 지어주세요!
InfoContent1, InfoContent2 이렇게 숫자로 변수의 속성을 나타내는 것 보다는 InfoContent 라는 하나의 공통된 변수로 표현해주는게 더욱 용이하다고 생각합니다

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ratafa ratafa ratafa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Chaehee03 @ratafa