-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: user #2
base: main
Are you sure you want to change the base?
feat: user #2
Conversation
|
||
@GetMapping("/me") | ||
fun getMyProfile( | ||
@AuthenticationPrincipal userDetails: UserDetails |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์ ๊ฐ ์ฃผ์
ํ MemberJwtToken์ SecurityContextHolder.getContext().authentication ๊ฐ์ฒด๋ฅผ ๊ฐ์ ธ์์ผํด์,
@userid userId:Long ๋ก ์ ๊ฐ ์ปค์คํ
ํ ์ด๋
ธํ
์ด์
์ ์ฌ์ฉํ์
์ผ ํ ๊ฒ ๊ฐ์ต๋๋ค.
companion object { | ||
fun toUserProfileResponse(user: User): UserProfileResponse { | ||
return UserProfileResponse( | ||
id = user.id ?: throw BusinessException(ErrorCode.USER_ID_NULL), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BusinessException์ ErrorCode๋ฅผ ๋ฃ๋ ๊ฒ๋ณด๋ค BusinessException ๊ฐ์ฒด๋ฅผ ์์ํ UserNullException ๊ฐ์ ๊ฑธ ๋ง๋ค์ด ์ฐ๋ ๊ฒ ๊ฐ์ต๋๋ค
|
||
@SpringBootApplication class SpringAccountApplication | ||
@SpringBootApplication @EnableCaching class SpringAccountApplication |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JVM ์บ์ฑ ์ฌ์ฉํ์ง ์์ผ๋ฉด ์ ๊ฑฐํด์ผ ํ ๊ฒ ๊ฐ์ต๋๋ค.
๐๏ธ ์ด PR์ ํตํด ํด๊ฒฐํ๋ ค๋ ๋ฌธ์ ๊ฐ ๋ฌด์์ธ๊ฐ์?
โจ ์ด PR์์ ํต์ฌ์ ์ผ๋ก ๋ณ๊ฒฝ๋ ์ฌํญ์ ๋ฌด์์ผ๊น์?
๐ ํต์ฌ ๋ณ๊ฒฝ ์ฌํญ ์ธ์ ์ถ๊ฐ์ ์ผ๋ก ๋ณ๊ฒฝ๋ ๋ถ๋ถ์ด ์๋์?
๐ Reviewer ๋ถ๋ค์ด ์ด๋ฐ ๋ถ๋ถ์ ์ ๊ฒฝ์จ์ ๋ด ์ฃผ์๋ฉด ์ข๊ฒ ์ด์
๐ฉบ ์ด PR์์ ํ ์คํธ ํน์ ๊ฒ์ฆ์ด ํ์ํ ๋ถ๋ถ์ด ์์๊น์?
๐ PR ์งํ ์ ์ด๋ฌํ ์ ๋ค์ ์ฐธ๊ณ ํด ์ฃผ์ธ์
๐ Assignee๋ฅผ ์ํ CheckList