This repository has been archived by the owner on Dec 5, 2023. It is now read-only.
Buttons affected for visual aid added #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoperez
suggested changes
Nov 19, 2023
src/app/components/Model.tsx
Outdated
| <h1 className='basis-[2%] ml-2'>Model</h1> | ||
| <button | ||
| className={`mr-4 px-2 py-0 text-xs ${copyText === 'Copied!' ? ' text-yellow-300' : ''}`} | ||
| onClick={() => { |
There was a problem hiding this comment.
Extract the method from the JSX.
geoperez
approved these changes
Nov 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added permanent colors when buttons are pressed, this way the user can know which mode its active.
Added the copy to clipboard button, now the user can easily copy all the text from the model or the result.
This last feature is still being developed as the testing threw some inconsistent behavior between browsers. As of now, Microsoft edge chromium v119 is the browser causing this strange behavior, when clicked the copy to clipboard button; the copy of the text will appear if pasted, but it will not appear on the clipboard giving the illusion as if nothing was copied.
Other tested browsers include chrome v119 and stack browser (chromium) beta v4.9.1, where the expected behavior of the button was observed.