Unused binding detection cleanup #5188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisPenner
commented
Jul 5, 2024
| @@ -147,7 +147,7 @@ debugPatternCoverageConstraintSolver = PatternCoverageConstraintSolver `Set.memb | |||
| debug :: (Show a) => DebugFlag -> String -> a -> a | |||
| debug flag msg a = | |||
| if shouldDebug flag | |||
| then (pTrace (msg <> ":\n" <> into @String (pShow a)) a) | |||
| then (trace (msg <> ":\n" <> into @String (pShow a)) a) | |||
There was a problem hiding this comment.
Double-pretty showing debug messages messes them up.
ChrisPenner
force-pushed
the
lsp/unused-binding-detection
branch
from
d2f5a89
to
dd17539
Compare
aryairani
approved these changes
Jul 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry this was meant to be part of the original PR, but I didn't notice my push got blocked because CI ran a formatting pass 馃檲 ;
Trunk is still in a good state I think, but this makes it just a little nicer.
Just combines the results into a single nice message rather than a separate diagnostic for each one.