Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to 15.0.0 #6

Open
wants to merge 2 commits into
base: staging
Choose a base branch
from

Conversation

mamtashukla
Copy link

Series include:
910cc98 Makefile.uk: add -std=c++20
1247952 Makefile.uk: Upgrade to 15.0.0

Fixes: unikraft/lib-compiler-rt#7

@razvand razvand self-assigned this Aug 5, 2023
@razvand razvand added the enhancement New feature or request label Aug 5, 2023
Copy link

@mariasfiraiala mariasfiraiala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mamtashukla, see my suggestion from below, and just like I mentioned in unikraft/lib-libcxx#3, in the commit message, right after the selector, use capital letter. This is for your Makefile.uk: add -std=c++20 commit.

Makefile.uk Outdated
@@ -85,7 +85,7 @@ endif
LIBCXXABI_SUPPRESS_FLAGS += -Wno-parentheses

LIBCXXABI_CFLAGS-y += $(LIBCXXABI_CONFIG_FLAGS)
LIBCXXABI_CXXFLAGS-y += $(LIBCXXABI_CONFIG_FLAGS)
LIBCXXABI_CXXFLAGS-y += $(LIBCXX_CONFIG_FLAGS) -std=c++2a
Copy link

@mariasfiraiala mariasfiraiala Aug 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
LIBCXXABI_CXXFLAGS-y += $(LIBCXX_CONFIG_FLAGS) -std=c++2a
LIBCXXABI_CXXFLAGS-y += $(LIBCXXABI_CONFIG_FLAGS) -std=c++2a

@mamtashukla
Copy link
Author

Thanks @mamtashukla, see my suggestion from below, and just like I mentioned in unikraft/lib-libcxx#3, in the commit message, right after the selector, use capital letter. This is for your Makefile.uk: add -std=c++20 commit.

Thanks for review.
v2:
-fix commit message
-use correct flags LIBCXX_CONFIG_FLAGS-> LIBCXXABI_CONFIG_FLAGS

Copy link

@mariasfiraiala mariasfiraiala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good on my part, now, thanks for the prompt update @mamtashukla!

Reviewed-by: Maria Sfiraiala [email protected]

Copy link
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mamtashukla. Please remove the long lines from the second commit message. Only Use -std=c++20 flag to allow constint will do.

Use -std=c++20 flag to allow constint

Signed-off-by: Mamta Shukla <[email protected]>
@mamtashukla
Copy link
Author

Thank you @mamtashukla. Please remove the long lines from the second commit message. Only Use -std=c++20 flag to allow constint will do.

Thanks! Updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🧊 Icebox
Development

Successfully merging this pull request may close these issues.

Update library to version 15.0.0
4 participants