-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to 15.0.0 #6
base: staging
Are you sure you want to change the base?
Conversation
Signed-off-by: Mamta Shukla <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mamtashukla, see my suggestion from below, and just like I mentioned in unikraft/lib-libcxx#3, in the commit message, right after the selector, use capital letter. This is for your Makefile.uk: add -std=c++20 commit.
Makefile.uk
Outdated
@@ -85,7 +85,7 @@ endif | |||
LIBCXXABI_SUPPRESS_FLAGS += -Wno-parentheses | |||
|
|||
LIBCXXABI_CFLAGS-y += $(LIBCXXABI_CONFIG_FLAGS) | |||
LIBCXXABI_CXXFLAGS-y += $(LIBCXXABI_CONFIG_FLAGS) | |||
LIBCXXABI_CXXFLAGS-y += $(LIBCXX_CONFIG_FLAGS) -std=c++2a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LIBCXXABI_CXXFLAGS-y += $(LIBCXX_CONFIG_FLAGS) -std=c++2a | |
LIBCXXABI_CXXFLAGS-y += $(LIBCXXABI_CONFIG_FLAGS) -std=c++2a |
910cc98
to
7e1640c
Compare
Thanks for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good on my part, now, thanks for the prompt update @mamtashukla!
Reviewed-by: Maria Sfiraiala [email protected]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @mamtashukla. Please remove the long lines from the second commit message. Only Use
-std=c++20 flag to allow constint
will do.
Use -std=c++20 flag to allow constint Signed-off-by: Mamta Shukla <[email protected]>
7e1640c
to
5b67071
Compare
Thanks! Updated. |
Series include:
910cc98 Makefile.uk: add -std=c++20
1247952 Makefile.uk: Upgrade to 15.0.0
Fixes: unikraft/lib-compiler-rt#7