Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-22939 DRAFT: WIP on function composition #3228

Draft
wants to merge 37 commits into
base: main
Choose a base branch
from
Draft

ICU-22939 DRAFT: WIP on function composition #3228

wants to merge 37 commits into from

Commits on Oct 1, 2024

  1. WIP on function composition

    @catamorphism
    catamorphism committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    e7e256e View commit details
    Browse the repository at this point in the history

  2. Fix warnings

    @catamorphism
    catamorphism committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    8cae40c View commit details
    Browse the repository at this point in the history

  3. Fix leaks

    @catamorphism
    catamorphism committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    71209d9 View commit details
    Browse the repository at this point in the history

  4. Fix doc comments and move InternalValue to a private header file

    @catamorphism
    catamorphism committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    c8d28b3 View commit details
    Browse the repository at this point in the history

  5. Extend InternalValue and eliminate ResolvedSelector

    @catamorphism
    catamorphism committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    a9d3547 View commit details
    Browse the repository at this point in the history

  6. Comments; renaming fields to be more informative

    @catamorphism
    catamorphism committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    135fec0 View commit details
    Browse the repository at this point in the history

  7. Remove commented-out code

    @catamorphism
    catamorphism committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    04b9cf2 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Fix leaks

    @catamorphism
    catamorphism committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    c048313 View commit details
    Browse the repository at this point in the history

  2. Remove unused method

    @catamorphism
    catamorphism committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    fe9f635 View commit details
    Browse the repository at this point in the history

  3. Fix warning

    @catamorphism
    catamorphism committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    2c4705a View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. Tests pass

    @catamorphism
    catamorphism committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    bb2ecdb View commit details
    Browse the repository at this point in the history

  2. Fixed leaks

    @catamorphism
    catamorphism committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    8d875ed View commit details
    Browse the repository at this point in the history

  3. Refactor

    @catamorphism
    catamorphism committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    0510d0a View commit details
    Browse the repository at this point in the history

  4. Remove FormattedPlaceholder and FormattedValue (no longer used)

    @catamorphism
    catamorphism committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    25e563f View commit details
    Browse the repository at this point in the history

  5. Re-add default formatters by type

    @catamorphism
    catamorphism committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    243bafe View commit details
    Browse the repository at this point in the history

  6. Rename functions

    @catamorphism
    catamorphism committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    acafbc6 View commit details
    Browse the repository at this point in the history

  7. Comments

    @catamorphism
    catamorphism committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    037b027 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Bring back FunctionFactory

    @catamorphism
    catamorphism committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    f82c921 View commit details
    Browse the repository at this point in the history

  2. Un-ignore a test; add comments

    @catamorphism
    catamorphism committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    10dfe45 View commit details
    Browse the repository at this point in the history

  3. Add doc comments

    @catamorphism
    catamorphism committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    a2f4a59 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Add test

    @catamorphism
    catamorphism committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    df5e654 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Fix ListValue

    @catamorphism
    catamorphism committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    abf6c80 View commit details
    Browse the repository at this point in the history

  2. Add u-options tests

    @catamorphism
    catamorphism committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    81d9acf View commit details
    Browse the repository at this point in the history

  3. Fix output checking

    @catamorphism
    catamorphism committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    a51dc3e View commit details
    Browse the repository at this point in the history

  4. Function context and u:options

    @catamorphism
    catamorphism committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    1abcef0 View commit details
    Browse the repository at this point in the history

  5. Fix date/time style bug

    @catamorphism
    catamorphism committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    b12bf30 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Fix test

    @catamorphism
    catamorphism committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    0cf0fc8 View commit details
    Browse the repository at this point in the history

  2. Fix datetime options bug

    @catamorphism
    catamorphism committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    50aea15 View commit details
    Browse the repository at this point in the history

  3. Remove FunctionFactory again

    @catamorphism
    catamorphism committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    6f140bb View commit details
    Browse the repository at this point in the history

  4. Re-add ResourceManager test

    @catamorphism
    catamorphism committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    c100e35 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Make Function::call() return a LocalPointer

    @catamorphism
    catamorphism committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    c199c1c View commit details
    Browse the repository at this point in the history

  2. Use an array of indices for prefs in selectKeys()

    @catamorphism
    catamorphism committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    f62fc64 View commit details
    Browse the repository at this point in the history

  3. Add comment about isSelectable()

    @catamorphism
    catamorphism committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    603bffa View commit details
    Browse the repository at this point in the history

  4. Remove use of std::string

    @catamorphism
    catamorphism committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    740ca4f View commit details
    Browse the repository at this point in the history

  5. Remove uses of new/delete

    @catamorphism
    catamorphism committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    e15e62b View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. Implement call-by-need; tests pass

    @catamorphism
    catamorphism committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    5343da5 View commit details
    Browse the repository at this point in the history

  2. depstest: add messageformat2_evaluation.o to ignore list (for spuriou… 

    …s reference to std::exception)
    @catamorphism
    catamorphism committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    7459872 View commit details
    Browse the repository at this point in the history