Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kwargs error #102

Merged
merged 12 commits into from
Nov 16, 2023
Merged

Kwargs error #102

merged 12 commits into from
Nov 16, 2023

Conversation

vladdez
Copy link
Collaborator

@vladdez vladdez commented Nov 14, 2023

No description provided.

@vladdez vladdez marked this pull request as ready for review November 14, 2023 20:58
@vladdez vladdez requested a review from behinger November 15, 2023 09:40
@behinger
Copy link
Member

giphy
looks good - so no problems with the kwargs afterall, just problems in docs/tests :)

@vladdez
Copy link
Collaborator Author

vladdez commented Nov 16, 2023

should i resolve and merge then?

@behinger
Copy link
Member

nt sure what happened now. I thought I already merged it

@behinger
Copy link
Member

ah sorry I confused myself.

@behinger
Copy link
Member

yes resolve and merge :)

@vladdez vladdez merged commit 400506a into main Nov 16, 2023
2 checks passed
@vladdez vladdez deleted the kwargsError branch November 16, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants