Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"8 plots -2" #101

Merged
merged 15 commits into from
Nov 30, 2023
Merged

"8 plots -2" #101

merged 15 commits into from
Nov 30, 2023

Conversation

vladdez
Copy link
Collaborator

@vladdez vladdez commented Nov 14, 2023

No description provided.

@unfoldtoolbox unfoldtoolbox deleted a comment from codecov bot Nov 24, 2023

This comment was marked as spam.

@vladdez vladdez marked this pull request as ready for review November 25, 2023 10:42
@vladdez vladdez requested a review from behinger November 25, 2023 10:42
@vladdez
Copy link
Collaborator Author

vladdez commented Nov 25, 2023

for some reasons docstrings do not work yet

data, positions = TopoPlots.example_data()
dat, evts = UnfoldSim.predef_eeg(;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we include this into https://github.com/unfoldtoolbox/UnfoldMakie.jl/blob/main/docs/example_data.jl ?

And is this different to the examples used there?

That would make it nicer imho :)

runner.jl Outdated
@@ -0,0 +1,62 @@
using Pkg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont understand this file - do we need it? If I understand correctly the auto-format github action should resolve this - it will come soon :S (not in my hands, the maintainer needs to update something)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no it is here accidentally
it is just my handle

plot_erpimage!(f[2, 1], times, d_nan; sortvalues=evts_fix.sac_startpos_x, visual=v)
plot_erpimage!(f[2, 2], times, d_nan; sortvalues=evts_fix.sac_amplitude, visual=v)
f
using UnfoldSim
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably can use the example_data.jl as mentioned abve here as well

@behinger behinger merged commit acff4b9 into main Nov 30, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants