-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: false positive with no-rename-default #157
base: master
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: b2d29e0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #157 +/- ##
==========================================
- Coverage 96.22% 96.00% -0.22%
==========================================
Files 91 101 +10
Lines 4399 4661 +262
Branches 1497 1595 +98
==========================================
+ Hits 4233 4475 +242
- Misses 160 180 +20
Partials 6 6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally I want to put this change on hold. The problem is more than _default
or index
. There is also mangled exports. See also #136
This PR fixes the false positive with the package "typescript-eslint" and "eslint-plugin-jsdoc".