Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: false positive with no-rename-default #157

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Zamiell
Copy link

@Zamiell Zamiell commented Sep 10, 2024

This PR fixes the false positive with the package "typescript-eslint" and "eslint-plugin-jsdoc".

Copy link

changeset-bot bot commented Sep 10, 2024

🦋 Changeset detected

Latest commit: b2d29e0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-import-x Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codesandbox-ci bot commented Sep 10, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.00%. Comparing base (8b53954) to head (70fe36a).
Report is 42 commits behind head on master.

Files with missing lines Patch % Lines
src/rules/no-rename-default.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #157      +/-   ##
==========================================
- Coverage   96.22%   96.00%   -0.22%     
==========================================
  Files          91      101      +10     
  Lines        4399     4661     +262     
  Branches     1497     1595      +98     
==========================================
+ Hits         4233     4475     +242     
- Misses        160      180      +20     
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@SukkaW SukkaW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally I want to put this change on hold. The problem is more than _default or index. There is also mangled exports. See also #136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants