-
-
Notifications
You must be signed in to change notification settings - Fork 16.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed manual accounting of field's count #12842
base: master
Are you sure you want to change the base?
Conversation
… text justification
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hello @igeni, thank you for submitting a YOLOv5 🚀 PR! To allow your work to be integrated as seamlessly as possible, we advise you to:
- ✅ Verify your PR is up-to-date with
ultralytics/yolov5
master
branch. If your PR is behind you can update your code by clicking the 'Update branch' button or by runninggit pull
andgit merge master
locally. - ✅ Verify all YOLOv5 Continuous Integration (CI) checks are passing.
- ✅ Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee
@igeni thank you for the PR and for your contributions towards making YOLOv5 better! 🌟 Your effort in refactoring the logging system to improve code readability and maintainability is indeed appreciated. Streamlining log message generation is crucial for both developers and users. It not only makes the codebase cleaner but also enhances the overall debugging and monitoring experience. Your focus on simplicity and consistency aligns well with our goals for YOLOv5. The changes outlined, from simplifying log formats to employing dynamic generation methods for strings, are valuable. Ensuring log messages follow a consistent format is key to a good user experience during model training and validation. We'll review the details and impact of your proposed changes closely. Your contribution helps us move towards a more efficient and user-friendly YOLOv5. Thanks again for your hard work and for being part of the YOLOv5 community! 🚀 |
All Contributors have signed the CLA. ✅ |
I have read the CLA Document and I sign the CLA |
@glenn-jocher At least 1 approving review is required :) |
@igeni Thanks for the reminder! We'll ensure your PR gets reviewed by the team 🚀. Keep an eye out for any comments or requests for changes from our reviewers. We appreciate your patience and contribution! |
Removed manual accounting of field's count and added option to change text justification
I have read the CLA Document and I hereby sign the CLA
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Refactoring log messages for simplicity and consistency 🛠️✨
📊 Key Changes
🎯 Purpose & Impact