Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capturing camera frame #69

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

yangga
Copy link
Contributor

@yangga yangga commented Oct 25, 2024

I have read the CLA Document and I sign the CLA

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

This PR introduces the ability to capture frames directly from the camera for both Android and iOS platforms in the YOLO Flutter app.

📊 Key Changes

  • Added functionality to capture camera frames on both Android and iOS:
    • Introduced requestCaptureVideo method in Android for capturing frames with a timeout.
    • Implemented frame capturing logic in iOS using CMSampleBuffer and DispatchSemaphore.
  • Enhanced the MethodCallHandler to handle the captureCamera method call in the Flutter app.
  • Updated Flutter's platform interface to include the captureCamera method.

🎯 Purpose & Impact

  • Purpose: Provide users the ability to capture and retrieve frames directly from the camera feed, enhancing the flexibility and functionality of the app.
  • Impact: Users will now be able to capture still images from the video feed, which can be useful for various purposes such as saving images, further image processing, or for visual verification in augmented reality applications. This can particularly enhance user experience in real-time applications.

Copy link

github-actions bot commented Oct 25, 2024

All Contributors have signed the CLA. ✅
Posted by the CLA Assistant Lite bot.

@UltralyticsAssistant UltralyticsAssistant added the enhancement New feature or request label Oct 25, 2024
@UltralyticsAssistant
Copy link
Member

👋 Hello @yangga, thank you for submitting a fantastic PR to the ultralytics/yolo-flutter-app 🚀! This is an automated response, but rest assured, an Ultralytics engineer will review your contribution soon.

Here's a quick checklist to help ensure your PR is ready for integration:

  • Define a Purpose: Ensure your PR description clearly explains the intent behind capturing camera frames and how it enhances the yolo-flutter-app. Providing a link to any related issue could help us track its context better.
  • Synchronize with Source: Double-check that your branch is up to date with the main branch of ultralytics/yolo-flutter-app. If not, consider merging the latest changes.
  • Ensure CI Checks Pass: Verify that all Continuous Integration (CI) checks are successful.
  • Update Documentation: If applicable, update documentation relevant to the new frame capture feature.
  • Add Tests: Please include tests ensuring functionality is covered, focusing on the new camera capturing logic.
  • Sign the CLA: It looks like you've already signed the Contributor License Agreement—thank you! 👏
  • Provide a Minimal Reproducible Example (MRE): Although your PR is focused on enhancements, when making changes related to features like camera operations, providing an MRE within your description can significantly aid in understanding the new functionality.

For further guidance, you are welcome to explore our Contributing Guide. If you have any uncertainties, please feel free to leave a comment below. We're excited to see your contribution live! 🎉

@yangga
Copy link
Contributor Author

yangga commented Oct 25, 2024

I have read the CLA Document and I sign the CLA

@glenn-jocher
Copy link
Member

@yangga thank you for the PR! @john-rocky can you review please?

@aabdulat1998
Copy link

please review so it can be merged

@pderrenger
Copy link
Member

@aabdulat1998 thank you for your contribution! The team will review your PR shortly. Please ensure all CI checks pass and that the PR aligns with the contributing guidelines to expedite the process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants