music modules: implement sanitize_words support for all music modules #2234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forgot to run tests, changing to a draft for now. |
dpeukert
force-pushed
the
sanitize-title
branch
from
6ade1f8
to
5d0ddcc
Compare
|
I've fixed the ordering errors, but I wasn't able to fix the docstring errors, which seem to be caused by the default value for sanitize_words being a constant. Not sure how to fix that. |
|
@ultrabug Apart from the ability to be able to configure the sanitized words (some people may want to exlude stuff like "(Live)", some may not), I don't really mind either way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the sanitize_words feature from the spotify module to other music modules. The common functionality has been added to the Py3 module.
I've tested all the modified modules and everything seems to be working as it should.