AI Logistics - Vehicles with route pickets #803

AnAngrySalad1 · 2021-03-08T15:08:20Z

When merged this pull request will:

Adds the initial code for review.
Runs off a wait and execute.
Known issues:
- Creates 1 visible agent and doesn't delete the agent.
- Randomly occurring script error around an '==' check in an IF statement but does seem to work still.

tbeswick96

Good start, some changes needed however.

Randomly occurring script error around an '==' check in an IF statement but does seem to work still

This is never ok. Script errors that appear to still work can't be written off as known issues.
(The error here is an undefined variable)

tbeswick96 · 2021-03-17T22:36:02Z

addons/aiaircommander/functions/fnc_handleDelete.sqf

-// TODO: Change this to use a common component for spawned AI deletion
-
-(_leader getVariable [QEGVAR(common,assignedVehicle), objNull]) call CBA_fnc_deleteEntity;
+(vehicle _leader) call CBA_fnc_deleteEntity;


Why has this changed? This is designed to delete the vehicle given to the unit at spawn, to cover cases where the unit is no longer inside the vehicle

When I first looked at it, I didn't remember assigning the vehicle with a setVar so thought it would return nothing. I've reverted it back.

addons/ailogistics/CfgVehicles.hpp

addons/ailogistics/README.md

addons/ailogistics/CfgVehicles.hpp

addons/ailogistics/XEH_PREP.hpp

addons/ailogistics/functions/fnc_logisticsMain.sqf

tbeswick96 · 2021-03-17T23:27:55Z

Also think using synchronized picket modules instead of the path calculation might be better and give greater control to the mission maker.
To ensure the vehicle still routes via each picket location, you could add a waypoint to each picket in turn (or to the nearest road if the picket is on the side of a hill for example)

AnAngrySalad1 · 2021-03-24T09:28:50Z

Also think using synchronized picket modules instead of the path calculation might be better and give greater control to the mission maker.
To ensure the vehicle still routes via each picket location, you could add a waypoint to each picket in turn (or to the nearest road if the picket is on the side of a hill for example)

I actually really like this, probably alot easier to. Might be able to change the picket behaviour to by using LAMBs camp or garrison.

- Various fixes - Correcting merge mistakes

AnAngrySalad1 · 2021-04-11T12:38:35Z

I've added code to make the logistics vehicle drive to the picket locations. It tries to find the nearest road to the picket location. If empty it'll just go to the picket location. An issue with this I can forsee is that if a picket is placed between say a fork and ends up travelling down a different road than mission maker intended so will require a degree of intelligent placement, not sure we could script for that outcome.

tbeswick96

Some previously resolved things marked as unresolved.

Few things highlighted in one place only (params ordering, changes to side), make sure changed in all relevant places

tbeswick96 · 2021-04-11T16:52:04Z

addons/ailogistics/functions/fnc_createLogisticVehicle.sqf

+[{
+    params ["_module"];
+    [_module] call FUNC(createLogisticVehicle);
+}, [_module], random _time] call cba_fnc_waitAndExecute;


This random _time needs to be considered with a minimum. This will currently resolve from 0 to _time.
If you want variance in the timeout, consider adding the base timeout to some random value. e.g
_time + random 60 or _time + random (_time / 10)

tbeswick96 · 2021-04-11T16:58:02Z

addons/ailogistics/CfgVehicles.hpp

+            };
+        };
+    };
+        class GVAR(logisticsPicketGroup) : GVAR(module) {


Bad indentation

tbeswick96 · 2021-04-11T16:59:34Z

addons/ailogistics/XEH_preInit.sqf

+GVAR(unitPoolString) = [];
+GVAR(logisticVehiclePoolString) = [];
+GVAR(routePickets) = false;
+GVAR(picketLocations) = [];
+GVAR(picketUnitPoolString) = [];
+GVAR(picketGroupSize) = 0;
+GVAR(logisticsObject) = ObjNull;
+GVAR(logisticalVehicleNumber) = 0;


If these variables are not used, remove them. Looks like everything is done via the module variables?

tbeswick96 · 2021-04-11T17:00:22Z

addons/ailogistics/functions/fnc_createLogisticVehicle.sqf

+
+if (!isServer) exitWith {};
+
+params ["_module"];


params first, before server check, for consistency

tbeswick96 · 2021-04-11T17:06:37Z

addons/ailogistics/functions/fnc_createPickets.sqf

+
+{
+    private _sideFromModule = _x getVariable [QGVAR(side), 0];
+    if (_sideFromModule == 0) then {


Is it planned that this could run twice for the same modules?
If so, the types are going to be out of whack due to the reassignment of the variable.

For robustness, I would resolve the side here for use only and leave the module variable intact as a number.

e.g

private _sideNumber = _x getVariable [QGVAR(side), 0]; private _side = [EAST, INDEPENDENT] select _sideNumber;

tbeswick96 · 2021-04-11T17:07:45Z

addons/ailogistics/functions/fnc_logisticWaypoints.sqf

+
+params ["_module", "_group"];
+
+private _destinationModule = (synchronizedObjects _module) select {_x isKindOf "uksf_ailogistics_logisticsDestination"};


Use the macro version instead of magic strings.
QGVAR(logisticsDestination)
and
QGVAR(logisticsPicketGroup)

tbeswick96 · 2021-04-11T17:11:29Z

addons/ailogistics/functions/fnc_moduleLogisticsStart.sqf

+} else {
+    _module setVariable [QGVAR(side), INDEPENDENT];
+};
+private _side = _module getVariable [QGVAR(side), EAST];


Same here for the side thing as above. Once you reassign this variable, if you read it anywhere else it'll be the wrong type

tbeswick96 · 2021-04-11T17:13:41Z

addons/ailogistics/CfgFactionClasses.hpp

@@ -0,0 +1,6 @@
+class CfgFactionClasses {
+    class EGVAR(common,eden);
+    class ADDON: EGVAR(common,eden){


Suggested change

class ADDON: EGVAR(common,eden){

class ADDON: EGVAR(common,eden) {

Initiat commit of V1, couple of issues that need fixing.

06fcbfc

tbeswick96 requested changes Mar 17, 2021

View reviewed changes

tbeswick96 assigned AnAngrySalad1 Mar 17, 2021

tbeswick96 changed the title ~~Initial commit of V1, couple of issues that need fixing.~~ AI Logistics Mar 17, 2021

tbeswick96 changed the title ~~AI Logistics~~ AI Logistics - Vehicles with route pickets Mar 17, 2021

tbeswick96 added this to the 5.19.18 milestone Mar 17, 2021

tbeswick96 added the type/feature label Mar 17, 2021

tbeswick96 modified the milestones: 5.19.18, 5.18.19, 5.19.19, 5.20.1, 5.20.2 Mar 27, 2021

Resolving an issue with not pulling before making changes:

a9ceeb0

- Various fixes - Correcting merge mistakes

AnAngrySalad1 and others added 5 commits April 11, 2021 13:46

Add check for nearRaods to use as waypoints.

b06ae5a

Merge branch 'master' into AI-Logistics

9a07550

Restore addons/resupply/$PBOPREFIX$

b7bf54d

Restore addons/resupply/README.md

cf64f03

Delete $PBOPREFIX$.txt

06fd0fa

tbeswick96 requested changes Apr 11, 2021

View reviewed changes

tbeswick96 modified the milestones: 5.20.2, 5.20.3 Apr 14, 2021

tbeswick96 modified the milestones: 5.20.3, 5.20.4, 5.20.5 May 1, 2021

tbeswick96 removed this from the 5.20.5 milestone May 14, 2021

tbeswick96 added this to the 5.20.6 milestone May 14, 2021

tbeswick96 modified the milestones: 5.20.6, 5.21.0 Jun 3, 2021

tbeswick96 mentioned this pull request Aug 16, 2021

Initial commit of scripted / ambient IEDs #857

Merged

tbeswick96 added 2 commits August 30, 2021 13:43

Merge branch 'master' into AI-Logistics

d6723e6

Merge branch 'IED' into AI-Logistics

434c6b1

tbeswick96 modified the milestones: 5.21.0, Backlog Sep 13, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AI Logistics - Vehicles with route pickets #803

AI Logistics - Vehicles with route pickets #803

AnAngrySalad1 commented Mar 8, 2021

tbeswick96 left a comment

tbeswick96 Mar 17, 2021

AnAngrySalad1 Mar 24, 2021

tbeswick96 commented Mar 17, 2021

AnAngrySalad1 commented Mar 24, 2021

AnAngrySalad1 commented Apr 11, 2021

tbeswick96 left a comment

tbeswick96 Apr 11, 2021

tbeswick96 Apr 11, 2021

tbeswick96 Apr 11, 2021

tbeswick96 Apr 11, 2021

tbeswick96 Apr 11, 2021

tbeswick96 Apr 11, 2021

tbeswick96 Apr 11, 2021

tbeswick96 Apr 11, 2021


		params ["_module", "_group"];

		private _destinationModule = (synchronizedObjects _module) select {_x isKindOf "uksf_ailogistics_logisticsDestination"};

	class ADDON: EGVAR(common,eden){
	class ADDON: EGVAR(common,eden) {

AI Logistics - Vehicles with route pickets #803

Are you sure you want to change the base?

AI Logistics - Vehicles with route pickets #803

Conversation

AnAngrySalad1 commented Mar 8, 2021

tbeswick96 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tbeswick96 commented Mar 17, 2021

AnAngrySalad1 commented Mar 24, 2021

AnAngrySalad1 commented Apr 11, 2021

tbeswick96 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment