Update WW3 for PIO/netCDF restarts #2445
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
at cc70186, the following files do not compare rt_cpld_mpi_gfsv17_intel.log: Comparing ufs.cpld.ww3.r.2021-03-23-21600 .....USING CMP......NOT IDENTICAL rt_cpld_mpi_pdlib_p8_intel.log: Comparing ufs.cpld.ww3.r.2021-03-23-21600 .....USING CMP......NOT IDENTICAL rt_cpld_restart_bmark_p8_intel.log: Comparing ufs.cpld.ww3.r.2013-04-01-21600 .....USING CMP......NOT IDENTICAL rt_cpld_restart_c192_p8_intel.log: Comparing ufs.cpld.ww3.r.2021-03-23-43200 .....USING CMP......NOT IDENTICAL
*add trho fix to w3iors, these ww3.r files do not compare *tested against bl.trhofix rt_cpld_mpi_gfsv17_intel.log:Test cpld_mpi_gfsv17_intel FAIL rt_cpld_mpi_pdlib_p8_intel.log:Test cpld_mpi_pdlib_p8_intel FAIL rt_cpld_restart_bmark_p8_intel.log:Test cpld_restart_bmark_p8_intel FAIL rt_cpld_restart_c192_p8_intel.log:Test cpld_restart_c192_p8_intel FAIL
* no write/read of fpis. these ww3.r files do not compare. tested against bl.trhofix.nofpis. all other files compare b4b rt_cpld_mpi_gfsv17_intel.log: Comparing ufs.cpld.ww3.r.2021-03-23-21600 .....USING CMP......NOT IDENTICAL rt_cpld_mpi_pdlib_p8_intel.log: Comparing ufs.cpld.ww3.r.2021-03-23-21600 .....USING CMP......NOT IDENTICAL
* fix typo in use_historync * remove mediator_present flag (unneeded)
* following pass baseline cpld_debug_noaero_p8 cpld_debug_pdlib_p8 hafs_regional_storm_following_1nest_atm_ocn_wav_mom6
* tested all wave-containing tests with modifications for restart file naming to allow for the custom filenaming of binary restarts. This feature is present in the current WW3 code, but will be removed once we enable netcdf restarts. Temporary code was added to allow the binary restart to have the existing format of casename+ww3.r+timestring. With this modification, all baselines were B4B.
* ww3 hash 4674dae passes against a self-generated baseline except for cpld_restart_gfsv17_intel * compare cmeps restart files of this uwm-hash against current baseline at develop-20240904. All are identical except for cpld_control_gfsv17_iau_intel
* ww3 0ad634c9 still fails slow restart, even though my sandbox testing passed.
* additional restart fields for WW3/slow loop coupling are requested via ww3 nml setting
* all med restart files are b4b w/ develop-20240904 baseline
* make fix for index in generic global read/write calls in wav_restart. this re-establishes b4b against bl.f9531d07
This reverts commit 8e3253c.
This reverts commit 4918975.
* ww3 restarts were temporarily removed from comparison lists but with netcdf restarts written and used for restart tests. all baselines passed against the develop-20240909 on hercules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Queue Requirements:
Description:
Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Changes
Regression Test Changes (Please commit test_changes.list):
New Baselines are required for all tests which include the WAV component. Answers do not change, but the comparison lists will now include the WW3 restart file. To verify no answer changes, the WW3 restarts were temporarily removed from comparison lists but with netcdf restarts written and used for restart tests. All baselines passed against the develop-20240909 on hercules at 0b0a048
Input data Changes:
Testing Log: