Combination for CCPP-physics #213 and #218 (H2O scheme refactor and C3/SAS/MYNN fix) #2408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 23, 2024
|
@grantfirl can you sync up your PR branch, please? |
@zach1221 Done |
zach1221
added
No Baseline Change
|
@FernandoAndrade-NOAA @BrianCurtis-NOAA we should be good to go here. |
|
@grantfirl fv3atm PR is merged. Hash: NOAA-EMC/fv3atm@40e014f |
jkbk2004
approved these changes
Aug 29, 2024
zach1221
approved these changes
Aug 29, 2024
DavidHuber-NOAA
added a commit
to DavidHuber-NOAA/ufs-weather-model
that referenced
this pull request
Sep 9, 2024
…r-model into develop * 'develop' of https://github.com/ufs-community/ufs-weather-model: update mom6 to its main repo. 20240824 commit (FMA) (ufs-community#2412) Update CMEPS; fix aux history functionality for float variable type; Switch to using Aux history files in atm_ds2s_docn_dice test; Remove IFI tests (was ufs-community#2417) (ufs-community#2395) Combination for CCPP-physics ufs-community#213 and ufs-community#218 (H2O scheme refactor and C3/SAS/MYNN fix) (ufs-community#2408) Unify CDEPS gfs, cfsr, and gefs datm datamodes + Improve error checking in rt.sh (2388) + Add ability to read increment files on native cubed sphere grid (2304) (ufs-community#2389) sync with head of NOAA-EMC UPP develop (ufs-community#2326) Allow use of downscaled warmstart files for cpld_control_sfs test (ufs-community#2375) update to MOM6 main 20240729 commit (gfdl-to-main-2024-05-31) (ufs-community#2381)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Queue Requirements:
Description:
This is a combination PR for work from @dustinswales (#2391) and @lisa-bengtsson (#2344)
Description for #2391
Included in this PR are changes to NRL's stratospheric h2o photochemistry scheme to make it "safe across multiple CCPP instances". These changes are identical to the reorganization that ufs-community/ccpp-physics#75.
Both schemes are called from a new module, GFS_photochemistry, at the start of the time-split section of the suite. Previously, the ozone scheme was called from GFS_stateout_update, and the h2o scheme was called just after.
Description for #2344
When running physics suites using C3 or SAS convection with the prognostic area fraction closure, and MYNN PBL, there is a bug in that the convection expects the field "tendency_of_vertically_diffused_tracer_concentration", to compute the turbulent moisture flux component of the total moisture convergence term, that is output from all PBL schemes except MYNN.
This PR updates the submodule pointer to FV3 and ccpp/physics which adds "tendency_of_vertically_diffused_tracer_concentration" as output from the MYNN PBL scheme
Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Changes
Regression Test Changes (Please commit test_changes.list):
Input data Changes:
Library Changes/Upgrades:
Testing Log: