Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add traditional threading templates for global apps and append _esmf for templates using ESMF-managed threading. #2179

Closed

Conversation

aerorahul
Copy link
Contributor

@aerorahul aerorahul commented Mar 7, 2024

Description:

This PR:

  • adds traditional threading ufs.configure templates for global applications where missing
  • appends _esmf to those global applications that uses ESMF managed threading
  • full RT pr-test result on hera:
    RegressionTests_hera.log

Commit Message:

* UFSWM - Allow flexibility to use traditional or ESMF-managed threading for global apps.

Priority:

  • Normal.

Git Tracking

UFSWM:

Sub component Pull Requests:

  • None

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • No Baseline Changes.

Input data Changes:

  • None

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@BrianCurtis-NOAA
Copy link
Collaborator

@jkbk2004. Without an objection from @aerorahul , this would be a good PR to combine with @DeniseWorthen #2172

@jkbk2004
Copy link
Collaborator

@jkbk2004. Without an objection from @aerorahul , this would be a good PR to combine with @DeniseWorthen #2172

Sure! We can combine those two PRs.

@aerorahul
Copy link
Contributor Author

@jkbk2004. Without an objection from @aerorahul , this would be a good PR to combine with @DeniseWorthen #2172

Sure! We can combine those two PRs.

Thanks @BrianCurtis-NOAA and @jkbk2004

@DeniseWorthen
Copy link
Collaborator

Combined with #2172. Closing.

@aerorahul aerorahul deleted the feature/ufs-threading branch March 11, 2024 17:23
zach1221 pushed a commit that referenced this pull request Mar 12, 2024
…g templates for global apps and append _esmf for templates using ESMF-managed threading (was #2179) (#2172)

* CICE and CMEPS - Remove compiler warnings.
* UFSWM - Allow flexibility to use traditional or ESMF-managed threading for global apps.
MatthewMasarik-NOAA added a commit to MatthewMasarik-NOAA/ufs-weather-model that referenced this pull request Mar 13, 2024
…aram

* origin/develop:
  Remove compiler warnings for CMEPS and CICE; Add traditional threading templates for global apps and append _esmf for templates using ESMF-managed threading (was ufs-community#2179) (ufs-community#2172)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants