Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix out of bound errors in block_atmos_copy routines in fv3atm #2124

Closed
wants to merge 4 commits into from
Closed

Fix out of bound errors in block_atmos_copy routines in fv3atm #2124

wants to merge 4 commits into from

Conversation

DusanJovic-NOAA
Copy link
Collaborator

@DusanJovic-NOAA DusanJovic-NOAA commented Feb 1, 2024 •
edited by BrianCurtis-NOAA
Loading

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full RT suite (compared to current baselines) on either Hera/Derecho/Hercules AND have committed the log to my PR branch.
  • Add list of all failed regression tests in "Regression Tests" section.

PR Information

Description

This PR fixes out of bounds array access in 6 overloaded block_atmos_copy subroutines in module_block_data (cpl/module_block_data.F90). See NOAA-EMC/fv3atm#776

Commit Message

Fix out of bound errors in block_atmos_copy routines in fv3tm

Priority

  • Critical Bugfix (This PR contains a critical bug fix and should be prioritized.)
  • High (This PR contains a feature or fix needed for a time-sensitive project (eg, retrospectives, implementations))
  • Normal

Blocking Dependencies

Git Issues Fixed By This PR

Closes NOAA-EMC/fv3atm/issues/776

Changes

Subcomponent (with links)

Input data

  • No changes are expected to input data.
  • Changes are expected to input data:
    • New input data.
    • Updated input data.

Regression Tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:
FAILED REGRESSION TESTS

Libraries

  • Not Needed
  • Needed
    • Create separate issue in JCSDA/spack-stack asking for update to library. Include library name, library version.
    • Add issue link from JCSDA/spack-stack following this item

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@DusanJovic-NOAA
Copy link
Collaborator Author

Hera regression test log: RegressionTests_hera.log

@BrianCurtis-NOAA BrianCurtis-NOAA added No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. labels Feb 1, 2024
@jkbk2004
Copy link
Collaborator

jkbk2004 commented Feb 8, 2024

@DusanJovic-NOAA can you sync up branch?

@DusanJovic-NOAA
Copy link
Collaborator Author

@DusanJovic-NOAA can you sync up branch?

Done.

@jkbk2004 jkbk2004 mentioned this pull request Feb 9, 2024
Merged
41 tasks
zach1221 pushed a commit that referenced this pull request Feb 10, 2024
@ulmononian
Updates for Gaea C5 & F2/F5 Transition + Fix out of bound errors in b…
760e002 
…lock_atmos_copy routines in fv3atm #2124 (#2115)

- Gaea C5 modulefile & DISKNM update: closes issues Gaea F2 to F5 file system migration #2101
- Bring in the global-workflow detect_machine.sh to keep consistent between projects. (Closes Bring in detect_machine.sh 
   from global workflow for consistency across the community. #2096 )
- Fix out of bound errors in block_atmos_copy routines in fv3atm
@DusanJovic-NOAA DusanJovic-NOAA deleted the block_atmos_copy_bug branch February 12, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrianCurtis-NOAA BrianCurtis-NOAA BrianCurtis-NOAA left review comments

Assignees
No one assigned
Labels
No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Array overflow bug in 'block_atmos_copy' subroutines
3 participants
@DusanJovic-NOAA @jkbk2004 @BrianCurtis-NOAA