Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] Verification upgrades and bug fixes #973

Merged
merged 73 commits into from
Jan 16, 2024

Commits on Nov 7, 2023

  1. Absorb {ACCUM_HH}h in file and directory names for ASNOW into the var…

    …iable fieldname_in_MET_filedir_names (as it is with APCP).
    gsketefian committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    c54bd0a View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. Configuration menu
    Copy the full SHA
    b766d2c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    da70c2e View commit details
    Browse the repository at this point in the history
  3. Further modifications for renaming from SFC and UPA to ADPSFC and ADP…

    …UPA, this time in METplus conf files.
    gsketefian committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    aad2eac View commit details
    Browse the repository at this point in the history
  4. In METplus conf files, change comparison operators in thresholds from…

    … ">=", ">", "<=", and "<" to "ge", "gt", "le", and "lt".
    gsketefian committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    a718921 View commit details
    Browse the repository at this point in the history
  5. Changes to METplus conf files: (1) FCST_VAR<n>_... and OBS_VAR<n>_...…

    … variables are grouped together, (2) commented-out settings of FCST_VAR<n>_... and OBS_VAR<n>_... are removed, (3) FCST_VAR<n>_OPTIONS and OBS_VAR<n>_OPTIONS come last, and (4) each element in options is on a separate line.
    gsketefian committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    50dd577 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    cd7b49f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    5d16582 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2023

  1. Configuration menu
    Copy the full SHA
    fa51d0a View commit details
    Browse the repository at this point in the history
  2. Clean up the way the METplus tool names are calculated; pass METplus …

    …tool names to template METplus conf files as variables; add new workflow variable that specifies the METplus verbosity level.
    gsketefian committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    e6fe549 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2023

  1. Change workflow scripts and METplus conf files so that all the vx tas…

    …ks for APCP (i.e. not just for accumulation > 1 hr but also for accumulation = 1 hour) use obs and forecast tasks that have been processed by the PcpCombine tool of METplus. These files are all in NetCDF format and are generated from grib2 input files (both for obs and forecast). This involves:
    
    * Renaming certain workflow variables for verification so their role/purpose is clearer.
    * Modifying the names of the arrays for APCP variables in the NetCDF files.
    * Changing the names of the levels associated with APCP variables in the NetCDF files (e.g. "A1" instead of "A01").
    * For consistency, making changes for accumulated snow (ASNOW) analogous to the above changes for APCP.
    * In ex-scripts for vx tasks, removing if-statement that treats the case of APCP accumulation period > 1 hour separately and performing the same steps for both accumulation = 1 hour and > 1 hour.
    gsketefian committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    9897066 View commit details
    Browse the repository at this point in the history
  2. The METplus variables [OBS|FCST]_NATIVE_DATA_TYPE are deprecated and …

    …should be replaced with [OBS|FCST]_PCP_COMBINE_INPUT_DATATYPE. Thus, they are only relevant to METplus conf files that run PcpCombine. Thus, remove all use of these variables in conf files that do not run PcpCombine, and in the ones that do, replace them with the appropriate new variables (some already have the new variables).
    gsketefian committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    cb06fa1 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2023

  1. Configuration menu
    Copy the full SHA
    76cc60b View commit details
    Browse the repository at this point in the history
  2. For GenEnsProd and EnsembleStat METplus tools, combine conf file temp…

    …lates for APCP01h and APCPgt01h.
    gsketefian committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    fef8d25 View commit details
    Browse the repository at this point in the history
  3. Add changes to ex-script for deterministic GridStat and PoinStat task…

    …s for combining METplus conf files for APCP01h and APCPgt01h (inadvertantly left out of a previous commit).
    gsketefian committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    bb570a4 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2023

  1. Configuration menu
    Copy the full SHA
    b781e3e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c0ba7fe View commit details
    Browse the repository at this point in the history
  3. Remove extra whitespace.

    gsketefian committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    adcd38c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8ed996f View commit details
    Browse the repository at this point in the history
  5. Remove all use of variable "field_is_APCPgt01h" since the METplus con…

    …f files no longer differentiate between 1 hour accumulation and > 1 hour accumulation.
    gsketefian committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    6beec34 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    86a4bd6 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e39ae1c View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2023

  1. Configuration menu
    Copy the full SHA
    8af9285 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b57667a View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2023

  1. Bug fix (OBSVAR7 --> OBS_VAR7); other minor changes to make it easier…

    … to compare ADP[SFC|UPA] conf files with other branches.
    gsketefian committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    9585845 View commit details
    Browse the repository at this point in the history
  2. Changes to make it easier to compare GenEnsProd conf files with those…

    … created using other branches.
    gsketefian committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    90dcda3 View commit details
    Browse the repository at this point in the history
  3. Changes to make it easier to compare EnsembleStat conf files with tho…

    …se created using other branches.
    gsketefian committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    d4c8502 View commit details
    Browse the repository at this point in the history
  4. Changes to make it easier to compare GridStat_ensprob conf files with…

    … those created using other branches.
    gsketefian committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    20c1195 View commit details
    Browse the repository at this point in the history
  5. More changes to make it easier to compare GenEnsProd and EnsembleStat…

    … conf files with those generated by another branch.
    gsketefian committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    896e3bd View commit details
    Browse the repository at this point in the history
  6. In METplus config template files that use "BOTH_VAR<n>_...", split th…

    …ese "BOTH" variables to two, one named "FCST_VAR<n>_..." and another named "OBS_VAR<n>_...".
    gsketefian committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    19152ee View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    8b6a6fd View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2023

  1. Configuration menu
    Copy the full SHA
    9c2c8db View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3be4460 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bced894 View commit details
    Browse the repository at this point in the history
  4. Make the thresholds for CAPE in GenEnsProd_ADPUPA.conf consistent wit…

    …h the ones in EnsembleStat_ADPUPA.conf.
    gsketefian committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    4c7f88b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    80741d2 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e919360 View commit details
    Browse the repository at this point in the history
  7. Clean up comments.

    gsketefian committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    13b7095 View commit details
    Browse the repository at this point in the history
  8. Fix up comments.

    gsketefian committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    e9a5368 View commit details
    Browse the repository at this point in the history
  9. Set verbosity level of PcpCombine tasks using workflow variable; remo…

    …ve commented code; fix variable name.
    gsketefian committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    0818802 View commit details
    Browse the repository at this point in the history
  10. Fix up comments.

    gsketefian committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    28aafdb View commit details
    Browse the repository at this point in the history
  11. Clean up comments.

    gsketefian committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    9728bdb View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2023

  1. Remove use of BOTH_ variables in deterministic conf files; modify com…

    …ments to make it easier to compare to output from another branch.
    gsketefian committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    fd58d4e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3e1b8f9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d35a7e1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7305347 View commit details
    Browse the repository at this point in the history
  5. Changes to comments.

    gsketefian committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    fda85e8 View commit details
    Browse the repository at this point in the history
  6. Remove variable ACCUM_HH in METplus conf files (and replace with jinj…

    …a varrriable {{accum_hh}}); simplify comments.
    gsketefian committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    f356a6c View commit details
    Browse the repository at this point in the history
  7. Minor comment fixes.

    gsketefian committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    0d535b5 View commit details
    Browse the repository at this point in the history
  8. Minor comment fixes.

    gsketefian committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    efcc635 View commit details
    Browse the repository at this point in the history
  9. Minor comment fixes.

    gsketefian committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    7e3b9ac View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2023

  1. Configuration menu
    Copy the full SHA
    780671c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d2a80ef View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    95d492f View commit details
    Browse the repository at this point in the history
  4. Remove internal variable FIELDNAME_IN_MET_FILEDIR_NAMES in EnsembleSt…

    …at_ADP[SFC|UPA].conf files.
    gsketefian committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    7fe7af9 View commit details
    Browse the repository at this point in the history
  5. Remove internal variable FIELDNAME_IN_MET_FILEDIR_NAMES in EnsembleSt…

    …at conf files in which it's still used.
    gsketefian committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    2750d49 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e134583 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2023

  1. Spacing fix.

    gsketefian committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    314f773 View commit details
    Browse the repository at this point in the history
  2. Spacing changes.

    gsketefian committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    a2883de View commit details
    Browse the repository at this point in the history
  3. In the METplus conf files for GridStat, GridStat_ensmean (which is no…

    …t actually run), and GridStat_ensprob processing REFC and RETOP, remove lines containing OBS_IS_PROB and OBS_GRID_STAT_PROB_THRESH since they are redundant.
    gsketefian committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    eea96dd View commit details
    Browse the repository at this point in the history
  4. Remove comented-out lines.

    gsketefian committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    ce2f098 View commit details
    Browse the repository at this point in the history
  5. For REFC and RETOP, modify the METplus conf files for GridStat, GridS…

    …tat_ensmean (which is not run), and GridStat_ensprob so that "cat_thresh = []" is replaced with "cat_thresh = [NA]". This is for consistency with the other METplus conf files.
    gsketefian committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    dfd21e3 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    fb7bc8c View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2023

  1. Configuration menu
    Copy the full SHA
    8e012d6 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2024

  1. Add the accumulation period (in hours) as a suffix to the names of AP…

    …CP fields being verified. This is so that MET's default observation error tables can be used (in which the APCP field names all include the accumulation periods, e.g. APCP_03).
    gsketefian committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    a0e3d99 View commit details
    Browse the repository at this point in the history
  2. Bug fix. Changes that should have been made as part of previous commi…

    …t to add accumulation period as a suffix to APCP field names.
    gsketefian committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    52cf89b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    26aaf87 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2024

  1. Add the accumulation hour as a suffix to the ASNOW forecast variable …

    …name. This is to be consistent with what is done for APCP. The same is not done for snow observations because that is not processed by PcpCombine to obtain a NetCDF file (so the name in the observation file must be that in the grib2, which does not include the accumulation hour suffix).
    gsketefian committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    2f5fcde View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    935cf5c View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2024

  1. Configuration menu
    Copy the full SHA
    1761430 View commit details
    Browse the repository at this point in the history
  2. Fix typo.

    gsketefian committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    cd94c85 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2024

  1. Configuration menu
    Copy the full SHA
    b2c78eb View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2024

  1. Configuration menu
    Copy the full SHA
    2743515 View commit details
    Browse the repository at this point in the history