Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/public-v2.2.0]: Documentation Updates #950

Conversation

gspetro-NOAA
Copy link
Collaborator

@gspetro-NOAA gspetro-NOAA commented Oct 19, 2023

DESCRIPTION OF CHANGES:

Implements changes in Issue #949.

Type of change

  • This change requires a documentation update

TESTS CONDUCTED:

None required. The human-readable version of my fork docs can be viewed here: https://srw-ug.readthedocs.io/en/text-release-updates/

  • hera.intel
  • orion.intel
  • hercules.intel
  • cheyenne.intel
  • cheyenne.gnu
  • derecho.intel
  • gaea.intel
  • gaeac5.intel
  • jet.intel
  • wcoss2.intel
  • NOAA Cloud (indicate which platform)
  • Jenkins
  • fundamental test suite
  • comprehensive tests (specify which if a subset was used)

DEPENDENCIES:

None.

DOCUMENTATION:

N/A. All documentation.

ISSUE:

Resolves Issue #949 .

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

LABELS (optional):

A Code Manager needs to add the following labels to this PR:

  • Work In Progress
  • bug
  • enhancement
  • documentation
  • release
  • high priority
  • run_ci
  • run_we2e_fundamental_tests
  • run_we2e_comprehensive_tests
  • Needs Cheyenne test
  • Needs Jet test
  • Needs Hera test
  • Needs Orion test
  • help wanted

CONTRIBUTORS (optional):

MichaelLueken and others added 25 commits October 9, 2023 11:51
…eously on Orion/Hercules and Gaea/Gaea C5 (ufs-community#921)

With the addition of Gaea C5 and Hercules to the Jenkinsfile, file contention between Gaea and Gaea C5, as well as Orion and Hercules, caused testing to fail for one of these two pairs of machines. While requeuing the failed machine would allow it to work, the automated tests should run automatically on all machines, simultaneously. The Platform team recommended adding the dir command to the stages' step sections in the Jenkinsfile. This has been completed and the Jenkins tests are now running on all machines simultaneously.
…e for new platforms (ufs-community#934)

The option to create an experiment with the option USE_CRON_TO_RELAUNCH=True is currently broken on Cheyenne and Derecho due to some bad python logic. This fixes that issue.

Also took the opportunity to update the PR template to include the new supported platforms (Derecho, Hercules, and Gaea C5)
@MichaelLueken MichaelLueken linked an issue Oct 27, 2023 that may be closed by this pull request
Copy link
Collaborator

@MichaelLueken MichaelLueken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gspetro-NOAA - I've reviewed the list of supported WE2E tests in the Tests.csv file and noted two tests that have been altered. I've also suggested adding JEDI to the DA entry in the introduction for the list of updates planned for the future (to explain why the GSI isn't being added to the SRW App).

@gspetro-NOAA gspetro-NOAA added documentation Improvements or additions to documentation release This PR/issue is related to a release branch labels Oct 30, 2023
Copy link
Collaborator

@MichaelLueken MichaelLueken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gspetro-NOAA - The modifications that I have requested have all been made. These changes look good to me, so I will now give my approval.

@MichaelLueken MichaelLueken merged commit 4f5573b into ufs-community:release/public-v2.2.0 Oct 30, 2023
3 checks passed
@gspetro-NOAA gspetro-NOAA deleted the text/release-updates branch January 29, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation release This PR/issue is related to a release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update documentation for v2.2.0 release
6 participants