Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop]: Update SRW/physics FAQ #928

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

gspetro-NOAA
Copy link
Collaborator

DESCRIPTION OF CHANGES:

@ligiabernardet requested some changes to one of our FAQs. The changes were vetted in this document. The update can be viewed in human-friendly form on RTD: https://srw-ug.readthedocs.io/en/text-faq/Reference/FAQ.html#addphys

Type of change

  • This change requires a documentation update

TESTS CONDUCTED:

None required. Text-only changes.

  • hera.intel
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss2.intel
  • NOAA Cloud (indicate which platform)
  • Jenkins
  • fundamental test suite
  • comprehensive tests (specify which if a subset was used)

DEPENDENCIES:

N/A.

DOCUMENTATION:

All documention! :)

ISSUE:

Issue #927

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • I have commented my code, particularly in hard-to-understand areas (N/A)
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes (N/A)
  • Any dependent changes have been merged and published

Copy link
Collaborator

@natalie-perlin natalie-perlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair update to the instructions, following a discussion with @ligiabernardet , and to warn users to be aware on possible issues with untested combinations. Approving.

@MichaelLueken MichaelLueken linked an issue Oct 6, 2023 that may be closed by this pull request
Copy link
Collaborator

@MichaelLueken MichaelLueken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gspetro-NOAA - These changes look good to me! It is very nice to see the addition of creating a GitHub Discussion in the SRW App repository, as well as the CCPP repositories, if users have questions or concerns about adding a new physics scheme.

Given the discussion between you and @ligiabernardet on these changes, I am giving my approval for these changes.

@MichaelLueken MichaelLueken merged commit aeb6de6 into ufs-community:develop Oct 6, 2023
3 checks passed
@gspetro-NOAA gspetro-NOAA deleted the text/faq branch January 29, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Physics FAQ Update
3 participants