Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] Modify workflow to use AQMv8 (CMAQ 5.4) #1134

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

BrianCurtis-NOAA
Copy link
Collaborator

DESCRIPTION OF CHANGES:

Bring in UFSWM changes that will bump hash to use AQM with CMAQ 5.4.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

TESTS CONDUCTED:

  • derecho.intel
  • gaea.intel
  • hera.gnu
  • hera.intel
  • hercules.intel
  • jet.intel
  • orion.intel
  • wcoss2.intel
  • NOAA Cloud (indicate which platform)
  • Jenkins
  • fundamental test suite
  • comprehensive tests (specify which if a subset was used)

DEPENDENCIES:

DOCUMENTATION:

ISSUE:

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

LABELS (optional):

A Code Manager needs to add the following labels to this PR:

  • Work In Progress
  • bug
  • enhancement
  • documentation
  • release
  • high priority
  • run_ci
  • run_we2e_fundamental_tests
  • run_we2e_comprehensive_tests
  • Needs Cheyenne test
  • Needs Jet test
  • Needs Hera test
  • Needs Orion test
  • help wanted

CONTRIBUTORS (optional):

@AnnaSmoot-NOAA

@BrianCurtis-NOAA
Copy link
Collaborator Author

When this moves closer to ready for review, will I need to have this working with the date 2023111100?

@MichaelLueken
Copy link
Collaborator

@BrianCurtis-NOAA -

Currently, the AQM WE2E test and sample configuration (ush/config.aqm.yaml) use 2023111100 for the cycle date. If you would like to update the cycle date, it would be possible, but it will take some coordination with the SI team to ensure that the updated data is available on all Tier-1 platforms (the AQM tests can run on Hera, Hercules, Orion, and Derecho). So, it would probably be easier to keep the 2023111100 date, but if you would like to update it, we can certainly do so.

Please let me know as soon as possible if you would like to update the cycle date and I will start coordinating with SI. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Work in Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants