-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop] Use uwtools instead of set_namelist #1054
Merged
MichaelLueken
merged 36 commits into
ufs-community:develop
from
christinaholtNOAA:replace_set_namelist
Mar 20, 2024
Merged
Changes from 24 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
5a9d7a2
Draft replacements in scripts.
christinaholtNOAA d135c68
Replace calls to set_namelist with uw CLI.
christinaholtNOAA c4eef3a
WIP
christinaholtNOAA 538c24d
WIP
christinaholtNOAA 819a48d
WIP
christinaholtNOAA ae106a7
Fix a typo.
christinaholtNOAA e84f6e2
Merge branch 'develop' into replace_set_namelist
christinaholtNOAA afe40d2
[develop] Add -n 1 to allow the use of the service partition
MichaelLueken 870b315
Updating and linting.
christinaholtNOAA 8140361
Renaming for PEP8 standard.
christinaholtNOAA 5d314a4
Linting.
christinaholtNOAA 46980b4
Linted.
christinaholtNOAA f25b5bc
WIP
christinaholtNOAA 2a11275
WIP
christinaholtNOAA 8e1f08c
Merge remote-tracking branch 'origin/develop' into replace_set_namelist
christinaholtNOAA 92010a3
[develop] Add native entry in aqm_prep.yaml for nexus_gfs_sfc
MichaelLueken a01d2fa
Merge remote-tracking branch 'leuken/bugfix/service_update' into repl…
christinaholtNOAA 6dc364f
hanges for new version and linted ush
christinaholtNOAA 0629b92
Merge branch 'develop' into replace_set_namelist
christinaholtNOAA 1d431e9
WIP
christinaholtNOAA b7c9bf3
Update CLI args for new uwtools version
christinaholtNOAA c166a77
Update uwtools version
christinaholtNOAA ca2a268
Add new linted ush files
christinaholtNOAA 8eedbd2
Remove debugging additions.
christinaholtNOAA d379eed
Fixing some doc strings in additional linted file.
christinaholtNOAA aa38beb
Linting tests.
christinaholtNOAA b866c68
Missed the updated name calls.
christinaholtNOAA 67d827f
Fix unlinted tests and make them pass.
christinaholtNOAA ea605c0
Changes from Mike K's PR comments.
christinaholtNOAA 1d6cd86
Use stdin instead of temporary files.
christinaholtNOAA 6256f1d
Fixing accidental revert to /bin/bash
christinaholtNOAA f18f801
Merge branch 'develop' into replace_set_namelist
christinaholtNOAA 6c020cf
[replace_set_namelist] Update Hera spack-stack locations to use Rocky8
MichaelLueken 327de17
Merge pull request #3 from MichaelLueken/replace_set_namelist
christinaholtNOAA 1b12beb
Fix issue with stochastic nml settings.
christinaholtNOAA ac6fe2d
Update test and lint.
christinaholtNOAA File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,4 +5,4 @@ channels: | |
dependencies: | ||
- pylint=2.17* | ||
- pytest=7.2* | ||
- uwtools=1.0.0 | ||
- uwtools=2.1* |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latest version of pyyaml did not need/want this tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this represent a potential back-compatibility issue for any yaml config files? If so it should probably be documented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gspetro-NOAA do you have a suggestion where this kind of information can/should go? Perhaps release notes would be sufficient, but in the absence of a release, do we have an ongoing list of changes since the release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also got a nice off-line suggestion to use
null
as the value here instead of leaving it blank. It will be more explicit and not make unfamiliar users feel like it might have been a mistake or oversight.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@christinaholtNOAA For what it's worth, issue #981 contains all of the PRs and their commit messages since the SRW v2.2.0 release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@christinaholtNOAA There's also a "Known Issues" page for issues related to
develop
or general issues. Known issues related to a specific release can be added to the appropriate release page in the Known Issues section.