Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failures on GFS_2017_gfdlmp suites #706

Merged
merged 1 commit into from
Mar 22, 2022
Merged

Fix failures on GFS_2017_gfdlmp suites #706

merged 1 commit into from
Mar 22, 2022

Conversation

chan-hoo
Copy link
Collaborator

@chan-hoo chan-hoo commented Mar 19, 2022

DESCRIPTION OF CHANGES:

Since the new parameter values for divergence damping, introduced in PR #657, cause the failures on the two CCPP suites; GFS_2017_gfldmp and GFS_2017_gfdlmp_regional, those values are changed back to the original ones only for the two CCPP suites.

TESTS CONDUCTED:

WE2E tests:

  • get_from_HPSS_ics_FV3GFS_lbcs_FV3GFS_fmt_nemsio (O)
  • get_from_HPSS_ics_GSMGFS_lbcs_GSMGFS (O)
  • new_ESGgrid (O)
  • specify_DOT_OR_USCORE (O)
  • grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_2017_gfdlmp (O)
  • grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_2017_gfdlmp_regional (O)
  • grid_RRFS_CONUS_25km_ics_GSMGFS_lbcs_GSMGFS_suite_GFS_2017_gfdlmp (O)
  • grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2 (O)
  • grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16 (O)
  • grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_RAP_suite_HRRR (O)
  • grid_RRFS_CONUS_25km_ics_HRRR_lbcs_HRRR_suite_RRFS_v1beta (O)
  • grid_RRFS_CONUS_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1alpha (O)

ISSUE:

CONTRIBUTORS:

@gsketefian

Copy link
Collaborator

@JeffBeck-NOAA JeffBeck-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for applying this fix, @chan-hoo!

@chan-hoo chan-hoo merged commit 405553b into ufs-community:develop Mar 22, 2022
@chan-hoo chan-hoo deleted the bugfix/div_damping branch March 23, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants