-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to the MYNN surface-layer scheme #58
Conversation
@grantfirl You may want to remove @ChunxiZhang-NOAA as a code owner. |
@joeolson42 @grantfirl I opened a PR into this branch replacing Chunxi @Qingfu-Liu. |
Thanks @dustinswales. Joe is testing this PR individually before we try to combine with #49. I think the latest status is that both individual PRs (this one and #49) are debugging a couple unexpected RT failures, which will be much easier to debug independently. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me, assuming RT results are as-expected. As mentioned, there is definitely still room for constant cleanup in a later PR, or when @joeolson42 does a more thorough re-write as discussed offline.
All tests successfully compiled and ran to completion. All tests using the MYNN surface-layer scheme were expected to fail the checks due to changes to the solution. The log files are attached. |
MYNN surface-layer scheme update:
Companion PRs:
ufs-community/ufs-weather-model#1678
NOAA-EMC/fv3atm#640