Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for new 'fixed' directories #986

Merged
merged 9 commits into from
Oct 1, 2024

Conversation

GeorgeGayno-NOAA
Copy link
Collaborator

@GeorgeGayno-NOAA GeorgeGayno-NOAA commented Sep 19, 2024

DESCRIPTION OF CHANGES:

The 'orog_raw' directory will be removed. Any needed files from 'orog_raw' will be pulled into 'orog'.
UFS_UTILS was updated accordingly.

TESTS CONDUCTED:

  • Run cpld_gridgen, global_cycle and grid_gen consistency tests locally on all Tier 1 machines. These tests point to the 'orog' directory. Used hash df2474b. All tests passed on WCOSS2, Jet, Hera, Hercules and Orion.
  • Run grid generation for each combination of "lake status" and "lake depth" on all Tier 1 machines. For test details, see: Retire the 'raw' orography directory #984 (comment) Using df2474b, ran with no errors on WCOSS2, Jet, Hera, Orion and Hercules.

Additional test: Changes from 'develop' were merged to the branch at 8ed4116. These changes included a big change to the orog program. So, I reran the grid_gen consistency tests on all Tier 1 machines. All passed as expected.

DEPENDENCIES:

N/A

DOCUMENTATION:

Minor updates to 'readthedocs' for broken AWS links to the fixed data:
https://georgegayno-noaaufs-utils.readthedocs.io/en/orog_raw/

ISSUE:

Fixes #984

CONTRIBUTORS:

@KateFriedman-NOAA

@GeorgeGayno-NOAA GeorgeGayno-NOAA marked this pull request as ready for review September 24, 2024 12:52
Copy link
Collaborator

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates to move away from the raw/orog fix files look good, thanks @GeorgeGayno-NOAA !

@GeorgeGayno-NOAA GeorgeGayno-NOAA merged commit 0c2c4b3 into ufs-community:develop Oct 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retire the 'raw' orography directory
2 participants