Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: in a collab setting, disable transactions that are trying to sync invalid content #5207

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

nperez0111
Copy link
Contributor

Changes Overview

This enables content checking for changes made by the collaboration plugin.
The changes made by the collaboration plugin are outside of the usual flow of content provided on initialization.
So, we need to handle it separately by filtering out the transactions where it occurs

Implementation Approach

Testing Done

Verification Steps

Additional Notes

Checklist

  • I have renamed my PR according to the naming conventions. (e.g. feat: Implement new feature or chore(deps): Update dependencies)
  • My changes do not break the library.
  • I have added tests where applicable.
  • I have followed the project guidelines.
  • I have fixed any lint issues.

Related Issues

Copy link

netlify bot commented Jun 4, 2024

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit 960bbe4
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/66845cbe680d080008e050a0
😎 Deploy Preview https://deploy-preview-5207--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nperez0111 nperez0111 force-pushed the develop branch 2 times, most recently from bcaef5c to 7e7ae19 Compare June 12, 2024 04:33
@nperez0111 nperez0111 force-pushed the feature/disable-invalid-collab branch from 21d8d1d to 42dee59 Compare June 13, 2024 21:13
@bdbch bdbch deleted the branch develop June 26, 2024 21:57
@bdbch bdbch closed this Jun 26, 2024
@nperez0111 nperez0111 reopened this Jun 27, 2024
@nperez0111 nperez0111 force-pushed the feature/disable-invalid-collab branch from 7138eac to 960bbe4 Compare July 2, 2024 20:02
Copy link

changeset-bot bot commented Jul 2, 2024

⚠️ No Changeset found

Latest commit: 960bbe4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants