Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Compatibility and Consistency for macOS (Apple Silicon) #18

Merged
merged 5 commits into from
Nov 25, 2024

Conversation

ruddyscent
Copy link
Contributor

@ruddyscent ruddyscent commented Nov 22, 2024

This PR introduces several improvements to enhance compatibility with macOS, particularly on Apple Silicon devices. It also addresses component naming consistency and resolves critical dependency issues.

macOS-Specific Updates:

  1. Removed .DS_Store Files:
    • Eliminated unnecessary .DS_Store files from the repository to maintain a cleaner codebase.
  2. Updated .gitignore:
    • Added comprehensive rules to ignore macOS-specific files, including:
    • .DS_Store, .AppleDouble, .Spotlight-V100, .Trashes, *.icloud.
    • Ensures compatibility and tidiness for macOS-based development environments.

Component Improvements:

  1. Train/Validation/Test Split Component:
    • Renamed the conda environment in conda.yml from download_file to train_val_test_split for clarity and alignment with the component’s purpose.
    • Updated the project name in MLproject to train_val_test_split to reflect the updated naming convention.
  2. Test Regression Model Component:
    • Updated conda.yml dependencies to resolve compatibility issues and address runtime errors:
    • Upgraded scikit-learn to 1.5.2 for consistency with the version used during model training.
    • Upgraded mlflow to 2.18.0 to fix the TypeError: ColSpec.init() got an unexpected keyword argument 'required' error during model loading.

- Added comprehensive rules for macOS-generated files and directories:
  - .DS_Store, .AppleDouble, .Spotlight-V100, .Trashes, etc.
  - Included iCloud-related files (*.icloud).
- Ensured better compatibility and cleanliness when using macOS environments.
- Renamed the conda environment from `download_file` to `train_val_test_split` in `conda.yml`.
- Ensures alignment between the environment name and the corresponding component.
- Renamed the project name in `MLproject` from `download_file` to `train_val_test_split`.
- Ensures consistency with the component's purpose and conda environment name.
- Updated `conda.yml` for the `test_regression_model` component to address compatibility issues:
  - Upgraded `scikit-learn` to 1.5.2 to match the version used during model saving.
  - Updated `mlflow` to 2.18.0 for improved support.
- This fixes the `TypeError: ColSpec.__init__() got an unexpected keyword argument 'required'` error encountered during model loading.
@ruddyscent ruddyscent changed the title Improve macOS Compatibility by Updating .gitignore and Removing .DS_Store Files Improve Compatibility and Consistency for macOS (Apple Silicon) Nov 24, 2024
@SudKul SudKul merged commit afed177 into udacity:main Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants