Added support for non-zero padding in instructions mvin and loop_conv_ws #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great, thank you! Do you think you could update Also, could you update No worries if you don't have the time to make these changes; I can add them myself. But it might be a bit before I have the time. |
|
Hi @hngenc, sorry for the delay. I added the padding_value in gemmini-rocc-tests to all places where it could be needed. See https://github.com/fzi-peccia/gemmini-rocc-tests/tree/non_zero_padding |
|
Hi @hngenc, I created the pull request for my changes in gemmini-rocc-tests ucb-bar/gemmini-rocc-tests#37 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to solve #229