v0.1.2: bug fixes #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ming1
commented
Mar 5, 2024
ming1
commented
- fix panic on assert!(host_cluster == off.0) in try_allocate_from()
- fix IO hang in heavy write & fsync
Let debug handle API level & slow meta logging. Signed-off-by: Ming Lei <[email protected]>
L1 table lock is just for preventing mapping table change from being happened. Signed-off-by: Ming Lei <[email protected]>
The helper is for flushing one kind of meta data, so rename it. Signed-off-by: Ming Lei <[email protected]>
flush_meta() acquires self.l1table.read(), but ensure_l2_offset() already holds self.l1table.write(), so deadlock is triggered. Fix it by add flush_mapping() which accepts l1 table directly. Signed-off-by: Ming Lei <[email protected]>
It isn't necessary to run flush_meta() concurrently, so add one mutex to serialize flushing meta for simplifying meta flush. Signed-off-by: Ming Lei <[email protected]>
If cluster in next refcount block is allocated, free the allocated and retry. TODO: re-investigate that why fixed allocation fails. Signed-off-by: Ming Lei <[email protected]>
Signed-off-by: Ming Lei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.