Release Workflow: multiple py versions and arm #678
Conversation
dvmarcilio
force-pushed
the
matrix_release
branch
from
5611f73
to
c1d6eae
Compare
pyproject.toml
Outdated
| @@ -1,6 +1,6 @@ | |||
| [project] | |||
| name = "polyglot_piranha" | |||
| requires-python = ">=3.7" | |||
| requires-python = ">=3.8" | |||
| description = "Polyglot Piranha is a library for performing structural find and replace with deep cleanup." | |||
| authors = [ | |||
| { name = "Ameya Ketkar", email = "[email protected]" }, | |||
There was a problem hiding this comment.
While we are here, maybe remove these two author entries since the emails don't work.
| run: | | ||
| pip install --upgrade maturin | ||
| - name: Build wheel with Maturin linux x86 | ||
| if: ${{ matrix.os == 'ubuntu-20.04' }} | ||
| run: | | ||
| maturin build --release -o dist |
There was a problem hiding this comment.
Why does this not specify a python version?
| matrix: | ||
| os: [ubuntu-latest, ubuntu-20.04, macos-latest] | ||
| python-version: ['3.8', '3.9', '3.10', '3.11', '3.12'] | ||
| runs-on: ${{ matrix.os }} |
There was a problem hiding this comment.
We could maybe use this: fromJSON('{"linux-x86": "ubuntu-20.04", "linux-arm": "ubuntu-latest", "macos": "macos-latest"}')[matrix.target]
And lets add a comment saying "We suspect we need 20.04 due to glibc not being new enough on Debian/devpod."
| release: | ||
| strategy: | ||
| matrix: | ||
| os: [ubuntu-latest, ubuntu-20.04, macos-latest] |
There was a problem hiding this comment.
how about having a target here instead of the OS? because that's what we are really trying to have a matrix for: linux-x86, linux-arm, macos-arm.
| run: | | ||
| pip install --upgrade maturin | ||
| - name: Build wheel with Maturin linux x86 | ||
| if: ${{ matrix.os == 'ubuntu-20.04' }} | ||
| run: | | ||
| maturin build --release -o dist | ||
| maturin build --sdist -o dist |
There was a problem hiding this comment.
Lets maybe have a separate step for the source distribution? It doesn't seem like it belongs with Linux x86 necessarily.
If we do that, we can combine all matrin steps (other than src) into one.
dvmarcilio
force-pushed
the
matrix_release
branch
from
b7db090
to
e6ba923
Compare
| - name: Build wheel with Maturin ${{ matrix.target }} | ||
| run: | | ||
| maturin build --release -o dist --target ${{ fromJSON('{"linux-x86":"x86_64-unknown-linux-gnu","linux-arm":"aarch64-unknown-linux-gnu","macos-arm":"universal2-apple-darwin"}')[matrix.target] }} -i ${{ matrix.python-version }} | ||
| - name: Build source distribution |
There was a problem hiding this comment.
Maybe say "Build source distribution (only once)" or add a comment next to the if to say why we are doing this only once.
Using a matrix strategy in the "Release Polyglot Piranha" workflows jobs to change python versions within [3.8; 3.12].
Moreover, adding more jobs to release for linux and macos ARM.
Successful execution of the workflow: https://github.com/uber/piranha/actions/runs/9909648923
Successful release of wheels in TestPyPi: https://test.pypi.org/project/polyglot-piranha-test/0.3.253a0/#files